1532319 - Log Points should have context

Status: RESOLVED FIXED

(DevTools :: Debugger, enhancement, P3)

Description

[Jason Laster [:jlast]]

It would be great if log points showed additional the context of where they were called. For instance, the function it was called in and its relationship with the prior log messages.

Comment 1

[Jason Laster [:jlast]]

Here is a prototype, which includes display names.

• nesting the display names (i.e. triggerEvents is indented) will be more interesting, but this is still valuable.
• the display name probably needs some more design polish as well to help it stand out.

https://github.com/jasonLaster/gecko-dev/commit/143315a128e20064c2eb33b298535bd1f0c719d3

Comment 2

[Jason Laster [:jlast]]

Attachment: Screen Shot 2019-03-17 at 10.12.49 PM.png

Comment 3

[:Harald Kirschner :digitarald]

I like the idea of method information in general. I'd imagine them grouped with the location/stack information on the right, as they provide similar insights.

I am not sure why Logpoints need them more than other console.logs. Logpoints are added by devs and then logged in the same session, so they are usually the most recent on their mind. Maybe we can get more crisp on what problem this is solving.

Comment 4

[Jan Honza Odvarko [:Honza] (always need-info? me)]

(In reply to :Harald Kirschner :digitarald from comment #3)

I like the idea of method information in general. I'd imagine them grouped with the location/stack information on the right, as they provide similar insights.

I am not sure why Logpoints need them more than other console.logs. Logpoints are added by devs and then logged in the same session, so they are usually the most recent on their mind. Maybe we can get more crisp on what problem this is solving.

I like this too. Is there any perf penalty we need to pay for displaying this additional info to the user?

Honza

Comment 5

[Jason Laster [:jlast]]

Related, it would be nice to see how often people log a single string, i.e. "hello" as a way of seeing that a line is run.

https://twitter.com/sebmck/status/1109644524995801088

One goal I have would be to make this simple case (a logPoint with an empty expression) a single click.

Comment 6

[:Harald Kirschner :digitarald]

Related, it would be nice to see how often people log a single string, i.e. "hello" as a way of seeing that a line is run.

Another solution would be also giving logpoints good default values, like function name and line.

Comment 7

[Jan Honza Odvarko [:Honza] (always need-info? me)]

(In reply to :Harald Kirschner :digitarald from comment #6)

Another solution would be also giving logpoints good default values, like function name and line.
I like that and plus perhaps function arguments.

Honza

Comment 8

[Jason Laster [:jlast]]

Just attached two screenshots, with context on nesting. The first has arrows, the second doesn't.

Nesting highlights function execution. e.g. triggerEvents is called by trigger. This should make it easier for users to read the logs.

As follow up items:

• It would be nice if all of the console messages followed the same nesting rules
• It would be nice for messages to actual be grouped by execution, so this means separating messages from different executions / threads, linking messages in an async frame...

Comment 9

[Jason Laster [:jlast]]

Attachment: nesting - logs (2).jpg

Comment 10

[Jason Laster [:jlast]]

Attachment: nesting logs.jpg

Comment 11

[Jason Laster [:jlast]]

Attachment: Bug 1532319 - Log Points should have context. r=dwalsh

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6bccd21b829d
Log Points should have context. r=davidwalsh

Comment 13

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/6bccd21b829d

Comment 14

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Hi, what are the STR to see editor.conditionalPanel.placeholder2 and editor.conditionalPanel.logPoint.placeholder2 in action?