Closed Bug 1532346 Opened 10 months ago Closed 9 months ago

Land release test interventions in Nightly

Categories

(Web Compatibility :: Interventions, defect, P1)

defect

Tracking

(firefox65 fixed, firefox66 fixed, firefox67 fixed)

RESOLVED FIXED
Tracking Status
firefox65 --- fixed
firefox66 --- fixed
firefox67 --- fixed

People

(Reporter: miketaylr, Assigned: denschub)

References

Details

Attachments

(3 files)

And we should request beta uplift once they're in Nightly for a day or so, so they don't disappear when beta merges to release.

Priority: -- → P1

As discussed with Aryx, I pushed two patches to this bug: One to land in central, and another one to land in beta, and get uplifted to release. In central, we already landed some broader changes, which will result in this patch not applying to beta. We also don't want to uplift all the changes in central to beta/release; the patch build for Beta and Release only includes changes that have already been shipped to release users via Balrog in bug 1527352.

Try pushes for both of these patches:

Nightly: https://treeherder.mozilla.org/#/jobs?repo=try&revision=6d06000ae83c0729c833b09aefa1c616502c28eb
Beta/Release: https://treeherder.mozilla.org/#/jobs?repo=try&revision=c746924a581df7502dbba81ee0b3d1c050383668

r=me -- these patches were already peer-reviewed and received QA signoff for release (via balrog).

Pushed by mitaylor@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0e7c56c0db48
Land WebCompat Release test interventions in tree. r=miketaylr

Comment on attachment 9048637 [details]
Bug 1532346 - Beta/Release - Land WebCompat Release test interventions in tree. r?miketaylr

Beta/Release Uplift Approval Request

  • Feature/Bug causing the regression: None
  • User impact if declined: Changes are already distributed to the release population via Balrog, see bug 1527352. This patch brings these changes into the tree, so that new version don't need to pull their updates from Balrog.
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Changes were tested by QA, rolled out to Release users, and we did not receive any reports about new issues.
  • String changes made/needed:
Attachment #9048637 - Flags: approval-mozilla-release?
Attachment #9048637 - Flags: approval-mozilla-beta?
Attachment #9048637 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Ryan, the release one is for you ;)

Flags: needinfo?(ryanvm)
Status: NEW → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED

Comment on attachment 9048637 [details]
Bug 1532346 - Beta/Release - Land WebCompat Release test interventions in tree. r?miketaylr

Pretty unlikely we'll be shipping another Fx65 dot release, but sure. As noted previously, this is simply landing system addon code in-tree which we're already pushing out to all users via Balrog anyway. Approved for mozilla-release.

Flags: needinfo?(ryanvm)
Attachment #9048637 - Flags: approval-mozilla-release? → approval-mozilla-release+

Comment on attachment 9048637 [details]
Bug 1532346 - Beta/Release - Land WebCompat Release test interventions in tree. r?miketaylr

This doesn't apply to m-r. Will need a rebased patch.

Attachment #9048637 - Attachment description: Bug 1532346 - Beta/Release - Land WebCompat Release test interventions in tree. r?miketaylr → Bug 1532346 - Beta - Land WebCompat Release test interventions in tree. r?miketaylr
Attachment #9048637 - Flags: approval-mozilla-release+
See Also: → 1533408

Comment on attachment 9049193 [details]
Bug 1532346 - Release - Land WebCompat Release test interventions in tree. r?miketaylr

Beta/Release Uplift Approval Request

  • Feature/Bug causing the regression: None
  • User impact if declined: Changes are already distributed to the release population via Balrog, see bug 1527352. This patch brings these changes into the tree, so that new version don't need to pull their updates from Balrog.
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Changes were tested by QA, rolled out to Release users, and we did not receive any reports about new issues.
  • String changes made/needed:
Attachment #9049193 - Flags: approval-mozilla-release?
Attachment #9049193 - Flags: approval-mozilla-release? → approval-mozilla-release+
Attachment #9048637 - Attachment description: Bug 1532346 - Beta - Land WebCompat Release test interventions in tree. r?miketaylr → Bug 1532346 - Beta/Release - Land WebCompat Release test interventions in tree. r?miketaylr
You need to log in before you can comment on or make changes to this bug.