Closed Bug 1532354 Opened 9 months ago Closed 9 months ago

Remove dead code from GMPServiceParent: ProcessPossiblePlugin and DeleteGMPServiceParent

Categories

(Core :: Audio/Video: GMP, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla67
Tracking Status
firefox67 --- fixed

People

(Reporter: bryce, Assigned: bryce)

Details

Attachments

(3 files)

While investigating Bug 1522547 I noticed that the ProcessPossiblePlugin function and DeleteGMPServiceParent class appear to be unused and can be safely removed.

Bug 1352924 removed the usage of this class, so we can safely remove the dead
code.

Depends on D21967

These functions already specify the override keyword. This change also makes
them more consistent with the overloaded versions of the same functions in these
classes.

Depends on D21968

Pushed by bvandyk@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c1e801670307
Remove GMPServiceParent::ProcessPossiblePlugin decl as it is unimplemented. r=cpearce
https://hg.mozilla.org/integration/autoland/rev/65fc1cf8774f
Remove unused DeleteGMPServiceParent class. r=cpearce
https://hg.mozilla.org/integration/autoland/rev/0bd2a637efa3
Remove virtual keyword on GMPServiceChild|GMPServiceParent::GetContentParent. r=cpearce
You need to log in before you can comment on or make changes to this bug.