Closed Bug 1532477 Opened 8 months ago Closed 8 months ago

LogicalRect::YMost() looks wrong

Categories

(Core :: Layout: Text and Fonts, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla67
Tracking Status
firefox67 --- fixed

People

(Reporter: hiro, Assigned: hiro)

Details

Attachments

(1 file)

It should return BEnd() instead of mBStart

The function is not used at all as of now, so it's not a big problem.

Pushed by hikezoe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7c5b913dc2e3
Return BEnd() from LogicalRect::YMost() in the case of non vertical. r=dholbert
Status: ASSIGNED → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67

Oops! Thanks for catching this -- good thing we weren't relying on it anywhere for now.

You need to log in before you can comment on or make changes to this bug.