Closed Bug 1532483 Opened 6 months ago Closed 6 months ago

Perma TV toolkit/content/tests/chrome/test_edit_contextmenu.html | paste enabled

Categories

(Toolkit :: XUL Widgets, defect, P5)

defect

Tracking

()

RESOLVED FIXED
mozilla67
Tracking Status
firefox-esr60 --- unaffected
firefox65 --- unaffected
firefox66 --- unaffected
firefox67 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: surkov)

References

Details

(Keywords: intermittent-failure, regression)

Attachments

(1 file, 1 obsolete file)

#[markdown(off)]
Filed by: apavel [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=231758692&repo=autoland

https://queue.taskcluster.net/v1/task/S1vYPlO2RqSVq2ff8ikvLA/runs/0/artifacts/public/logs/live_backing.log

[task 2019-03-04T22:56:44.251Z] 22:56:44 INFO - TEST-START | toolkit/content/tests/chrome/test_edit_contextmenu.html
[task 2019-03-04T22:56:44.275Z] 22:56:44 INFO - GECKO(1065) | ++DOMWINDOW == 33 (0x7f590ee80c00) [pid = 1065] [serial = 33] [outer = 0x7f5916603c00]
[task 2019-03-04T22:56:45.281Z] 22:56:45 INFO - GECKO(1065) | ++DOMWINDOW == 34 (0x7f590ee8cc00) [pid = 1065] [serial = 34] [outer = 0x7f5916603c00]
[task 2019-03-04T22:56:45.378Z] 22:56:45 INFO - GECKO(1065) | ++DOCSHELL 0x7f590ed20000 == 12 [pid = 1065] [id = {d21871ce-5a9b-4549-8950-07b5a8c1b9da}]
[task 2019-03-04T22:56:45.379Z] 22:56:45 INFO - GECKO(1065) | ++DOMWINDOW == 35 (0x7f591150cc00) [pid = 1065] [serial = 35] [outer = (nil)]
[task 2019-03-04T22:56:45.380Z] 22:56:45 INFO - GECKO(1065) | ++DOMWINDOW == 36 (0x7f591150f800) [pid = 1065] [serial = 36] [outer = 0x7f591150cc00]
[task 2019-03-04T22:56:45.556Z] 22:56:45 INFO - GECKO(1065) | [1065, StreamTrans #45] WARNING: 'NS_FAILED(rv)', file /builds/worker/workspace/build/src/modules/libjar/nsJARChannel.cpp, line 371
[task 2019-03-04T22:56:45.605Z] 22:56:45 INFO - GECKO(1065) | [1065, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80520012: file /builds/worker/workspace/build/src/modules/libjar/nsJARChannel.cpp, line 993
[task 2019-03-04T22:56:45.621Z] 22:56:45 INFO - TEST-INFO | started process screentopng
[task 2019-03-04T22:56:45.988Z] 22:56:45 INFO - TEST-INFO | screentopng: exit 0
[task 2019-03-04T22:56:45.989Z] 22:56:45 INFO - Buffered messages logged at 22:56:45
[task 2019-03-04T22:56:45.989Z] 22:56:45 INFO - must wait for focus
[task 2019-03-04T22:56:45.989Z] 22:56:45 INFO - TEST-PASS | toolkit/content/tests/chrome/test_edit_contextmenu.html | textarea exists
[task 2019-03-04T22:56:45.990Z] 22:56:45 INFO - Synthesizing a key so 'Undo' will be enabled
[task 2019-03-04T22:56:45.990Z] 22:56:45 INFO - TEST-PASS | toolkit/content/tests/chrome/test_edit_contextmenu.html | initial value
[task 2019-03-04T22:56:45.990Z] 22:56:45 INFO - Calling prevent default on the first contextmenu event
[task 2019-03-04T22:56:45.991Z] 22:56:45 INFO - TEST-PASS | toolkit/content/tests/chrome/test_edit_contextmenu.html | contextmenu with preventDefault() doesn't run
[task 2019-03-04T22:56:45.992Z] 22:56:45 INFO - TEST-PASS | toolkit/content/tests/chrome/test_edit_contextmenu.html | context menu exists after right click
[task 2019-03-04T22:56:45.993Z] 22:56:45 INFO - TEST-PASS | toolkit/content/tests/chrome/test_edit_contextmenu.html | undo enabled
[task 2019-03-04T22:56:45.994Z] 22:56:45 INFO - TEST-PASS | toolkit/content/tests/chrome/test_edit_contextmenu.html | cut disabled
[task 2019-03-04T22:56:45.994Z] 22:56:45 INFO - TEST-PASS | toolkit/content/tests/chrome/test_edit_contextmenu.html | copy disabled
[task 2019-03-04T22:56:45.995Z] 22:56:45 INFO - Buffered messages finished
[task 2019-03-04T22:56:45.997Z] 22:56:45 INFO - TEST-UNEXPECTED-FAIL | toolkit/content/tests/chrome/test_edit_contextmenu.html | paste enabled
[task 2019-03-04T22:56:45.998Z] 22:56:45 INFO - SimpleTest.ok@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:275:18
[task 2019-03-04T22:56:45.999Z] 22:56:45 INFO - runTest@chrome://mochitests/content/chrome/toolkit/content/tests/chrome/test_edit_contextmenu.html:46:7
[task 2019-03-04T22:56:45.999Z] 22:56:45 INFO - async*onload@chrome://mochitests/content/chrome/toolkit/content/tests/chrome/test_edit_contextmenu.html:1:1
[task 2019-03-04T22:56:46.000Z] 22:56:46 INFO - TEST-PASS | toolkit/content/tests/chrome/test_edit_contextmenu.html | delete disabled
[task 2019-03-04T22:56:46.001Z] 22:56:46 INFO - TEST-PASS | toolkit/content/tests/chrome/test_edit_contextmenu.html | select all enabled
[task 2019-03-04T22:56:46.002Z] 22:56:46 INFO - GECKO(1065) | [1065, Main Thread] WARNING: '!NodeIsInTraversalRange( mLast, mPre, RawRangeBoundary(mFirst, 0), aEnd)', file /builds/worker/workspace/build/src/dom/base/ContentIterator.cpp, line 265
[task 2019-03-04T22:56:46.003Z] 22:56:46 INFO - GECKO(1065) | [1065, Main Thread] WARNING: '!NodeIsInTraversalRange( mLast, mPre, RawRangeBoundary(mFirst, 0), aEnd)', file /builds/worker/workspace/build/src/dom/base/ContentIterator.cpp, line 265
[task 2019-03-04T22:56:46.003Z] 22:56:46 INFO - TEST-PASS | toolkit/content/tests/chrome/test_edit_contextmenu.html | undo worked
[task 2019-03-04T22:56:46.004Z] 22:56:46 INFO - GECKO(1065) | MEMORY STAT vsizeMaxContiguous not supported in this build configuration.
[task 2019-03-04T22:56:46.006Z] 22:56:46 INFO - GECKO(1065) | MEMORY STAT | vsize 1893MB | residentFast 347MB | heapAllocated 129MB
[task 2019-03-04T22:56:46.006Z] 22:56:46 INFO - TEST-OK | toolkit/content/tests/chrome/test_edit_contextmenu.html | took 1420ms

Summary: Intermittent toolkit/content/tests/chrome/test_edit_contextmenu.html | paste enabled → Perma TV toolkit/content/tests/chrome/test_edit_contextmenu.html | paste enabled

This seems to have been introduced with landing bug 1531155.

:asurkov can you, please, take a look?

Flags: needinfo?(surkov.alexander)

Apparently I landed the patch with the test enabled. Let me check if I can implement Neil's approach from 1531155 comment #7. Otherwise let's just disable that line for now

Flags: needinfo?(surkov.alexander)

(In reply to Neil Deakin from comment #6)

You could just stick something on the clipboard beforehand if needed using SimpleTest.promiseClipboardChange.

would it be something like:

let clipboard = Cc["@mozilla.org/widget/clipboardhelper;1"].getService(Ci.nsIClipboardHelper);
await SimpleTest.promiseClipboardChange("",
() => {
clipboard.copyString("");
}
);

You'd need to move the test into the clipboard subsuite as well.

where this place would be? I looked for promiseClipboardChange [1] and it seems they are mostly scattered through browser and dom tests. There's a toolkit one btw [2]

[1] https://searchfox.org/mozilla-central/search?q=promiseClipboardChange&path=
[2] https://searchfox.org/mozilla-central/source/toolkit/components/extensions/test/mochitest/test_ext_async_clipboard.html#188

Flags: needinfo?(enndeakin)

(In reply to alexander :surkov (:asurkov) from comment #3)

let clipboard = Cc["@mozilla.org/widget/clipboardhelper;1"].getService(Ci.nsIClipboardHelper);
await SimpleTest.promiseClipboardChange("",
() => {
clipboard.copyString("");
}
);

Something like that might work.

You'd need to move the test into the clipboard subsuite as well.

where this place would be? I looked for promiseClipboardChange [1] and it seems they are mostly scattered through browser and dom tests. There's a toolkit one btw [2]

You need to set 'subsuite = clipboard' in the mochitest.ini file for that test.

But I realized that for this particular test, you don't actually care that the system clipboard has been updated, just that the command state has, so rather than doing either of those things above you could just select some text and synthesize a copy keyboard shortcut or use execCommand.

Flags: needinfo?(enndeakin)
Attachment #9048560 - Attachment is obsolete: true
Pushed by asurkov@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8a2800ad38ad
Perma TV toolkit/content/tests/chrome/test_edit_contextmenu.html | paste enabled, r=NeilDeakin
Status: NEW → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
Assignee: nobody → surkov.alexander
You need to log in before you can comment on or make changes to this bug.