1532562 - Inconsistent launcher process status between about:support and telemetry

Status: RESOLVED DUPLICATE of bug 1531902

(Firefox :: General, defect, P1)

Description

[Rares Doghi, Desktop QA]

[Affected versions]:
Nightly 67.0a1

[Affected platforms]:
Platforms: Windows

Steps :

1. Launch the Firefox Browser On a Windows 8.1 with Norton Antivirus installed.
2. Reach about:support and check the Launcher Process = Enabled.
3. Reach about:telemetry#environment-data-tab_settings and search for Process.
4. Check the launcherProcessState = 0
5. Reach about:preferences and Select to NEVER remember History and Restart the browser.
6. Reach about:support and check the Launcher Process = Enabled.
7. Reach about:telemetry#environment-data-tab_settings and search for Process.

Expected Results :

When about:support shows the Enabled status the about:telemetry#environment-data-tab_settings should display 0.

Actual Results :

About:support shows Enabled but the telemetry shows 1 instead of 0.
Please also note that when the user Checks to Never Remember history and restarts the Browser the About:support shows Enabled but about:telemetry#environment-data-tab_settings shows 2 (disabled forcibly) for the LauncherProcess instead of 0.

This issue is not limited to Windows 8.1 or the Norton Antivirus, this issue also occurred on Windows 7 with AVG but on other systems its not as easy to reproduce, on Windows 8.1 it can be reproduced 100% of the time.

Comment 1

[Rares Doghi, Desktop QA]

After further testing I'm inclined to think that Restarting the Browser from the Never Remember History pop up is the cause of the Launcher process to show 2 in telemetry and not the actual option since Restarting from about:profiles with the Restart Normally option does the same thing.

Comment 2

[Rares Doghi, Desktop QA]

We also noticed that with the same machine, only logged in with a non-admin user the launcher process starts and shows enabled instead of 1 or 2.

Comment 3

[(No longer employed by Mozilla) Aaron Klotz]

This bug is going to focus specifically on restarting from the "Never Remember History" pop-up. Please separate any other issues into a separate bug.

Comment 4

[(No longer employed by Mozilla) Aaron Klotz]

Hmm, but nsAppStartup delegates the actual restart to LaunchChild, which is launcher process aware...

Comment 5

[Rares Doghi, Desktop QA]

Hi, just a quick mention this issue occurs when you restart the Firefox browser in any way possible. From the Never Remember prompt as well as the about:profiles > restart normally.

Comment 6

[Rares Doghi, Desktop QA]

The Problem here is also the fact that the About:support Shows Enabled instead of the correct status you can find in telemetry.

Comment 7

[(No longer employed by Mozilla) Aaron Klotz]

This is fixed by bug 1531902, which saves the launcher process state during startup so that about:support and telemetry reflect whether the launcher process actually ran at startup, as opposed to reflecting the state of any configurations that happened during the session (we want the former, not the latter).