Closed
Bug 1532576
Opened 5 years ago
Closed 5 years ago
Fallback openh264 gmp source file is out of date
Categories
(Core :: WebRTC: Audio/Video, enhancement, P2)
Tracking
()
RESOLVED
FIXED
mozilla68
People
(Reporter: dminor, Assigned: Callek)
References
Details
Attachments
(1 file)
47 bytes,
text/x-phabricator-request
|
pascalc
:
approval-mozilla-beta+
|
Details | Review |
The toolkit/content/gmp-sources/openh264.json file is used as a fallback if the AUS servers are not reachable. It was not updated for 1.7.1, we should update it for 1.8.1.
Reporter | ||
Updated•5 years ago
|
Rank: 15
Priority: P1 → P2
Reporter | ||
Comment 1•5 years ago
|
||
Callek, is this something you would be able to take a look at?
Flags: needinfo?(bugspam.Callek)
Assignee | ||
Comment 2•5 years ago
|
||
Assignee | ||
Updated•5 years ago
|
Flags: needinfo?(bugspam.Callek)
Pushed by jwood@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/305284b53c3c Fallback openh264 gmp source file is out of date. r=dminor
Comment 4•5 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox68:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
Updated•5 years ago
|
Assignee: nobody → bugspam.Callek
Reporter | ||
Comment 5•5 years ago
|
||
Comment on attachment 9060072 [details]
Bug 1532576 - Fallback openh264 gmp source file is out of date. r=dminor
Beta/Release Uplift Approval Request
- User impact if declined: Users will be served old version of OpenH264 plugin if network fallback from Balrog is required. We missed updating this file for the 1.7.1 update and didn't see any bug reports, so I don't think this has much of an impact in practice, but there is very little risk to taking the patch.
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): This is very low risk, it changes the URLs used to retrieve the OpenH264 plugin in the event that Balrog is unreachable.
- String changes made/needed: None
Attachment #9060072 -
Flags: approval-mozilla-beta?
Comment 6•5 years ago
|
||
Comment on attachment 9060072 [details]
Bug 1532576 - Fallback openh264 gmp source file is out of date. r=dminor
Uplift accepted for 67 beta 16, thanks.
Attachment #9060072 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment 7•5 years ago
|
||
bugherder uplift |
status-firefox67:
--- → fixed
See Also: → 1587543
You need to log in
before you can comment on or make changes to this bug.
Description
•