Closed Bug 1532632 Opened 2 years ago Closed 2 years ago

Use readonly="readonly" instead readonly="true" for textareas

Categories

(Toolkit :: General, enhancement, P5)

Product:
Toolkit
Component:
General
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla67
Tracking Flags:
Tracking Status
firefox67 --- fixed

People

(Reporter: ntim, Assigned: m.boselli)

References

Details

(Keywords: good-first-bug)

Attachments

(1 file, 1 obsolete file)

Bug 1532632 . Use readonly="readonly" instead readonly="true" for textareas
2.69 KB, patch
Details | Diff | Splinter Review

See https://bugzilla.mozilla.org/show_bug.cgi?id=1513343#c28

Here are the affected files:

dom/xslt/tests/XSLTMark/XSLTMark.xul
security/manager/pki/resources/content/certViewer.xul
security/manager/pki/resources/content/clientauthask.xul
toolkit/mozapps/update/content/updates.xul

Keywords: good-first-bug
Priority: -- → P5

Hello, :mkaply,
I would like to work on this issue

Hi! my name is Divya and I want to apply as an Outreachy intern. Can you please assign this issue to me?

If you'd like to work on it, please feel free just submit a patch and I'll assign this to the first person who does so.

Assignee: nobody → m.boselli
Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ca92aeb9192d
Use readonly="readonly" instead of readonly="true" for textareas. r=ntim

Thanks Milena! I've landed the patch.

Karan, your patch was fine as well, but Milena was first, sorry for the trouble :(. You can look for a different bug at: https://codetribute.mozilla.org/ if you're interested.

https://hg.mozilla.org/mozilla-central/rev/ca92aeb9192d

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox67: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla67

(In reply to Tim Nguyen :ntim from comment #7)

Thanks Milena! I've landed the patch.

Karan, your patch was fine as well, but Milena was first, sorry for the trouble :(. You can look for a different bug at: https://codetribute.mozilla.org/ if you're interested.

It looks like the patch that landed missed https://searchfox.org/mozilla-central/rev/fbb251448feb7276f9b1d0a88f9c0cb1cd144ce4/security/manager/pki/resources/content/certViewer.xul#119-120 . Also, shouldn't that be html:textarea ?

Flags: needinfo?(ntim.bugs)
Attachment #9048750 - Attachment is obsolete: true

(In reply to :Gijs (he/him) from comment #9)

It looks like the patch that landed missed https://searchfox.org/mozilla-central/rev/fbb251448feb7276f9b1d0a88f9c0cb1cd144ce4/security/manager/pki/resources/content/certViewer.xul#119-120.

Thanks for catching that!

Also, shouldn't that be html:textarea ?

No, the parent table already has xmlns="http://www.w3.org/1999/xhtml" on it.

Flags: needinfo?(ntim.bugs)
Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/41c00dfcd1b6
Followup: replace readonly="true" with readonly="readonly" in certViewer.xul's second textarea. r=me
You need to log in before you can comment on or make changes to this bug.