Closed Bug 1532673 Opened 1 year ago Closed 1 year ago

"Stop using safe mode" help access key is never used

Categories

(Firefox :: General, enhancement, P5)

enhancement

Tracking

()

RESOLVED FIXED
Firefox 67
Tracking Status
firefox67 --- fixed

People

(Reporter: Gijs, Assigned: sapoliakaran, Mentored)

Details

(Keywords: good-first-bug, Whiteboard: [lang=js])

Attachments

(2 files)

https://searchfox.org/mozilla-central/rev/92d11a33250a8e368c8ca3e962e15ca67117f765/browser/base/content/browser.js#1572

The access key property has a capital K, and so this setting of it doesn't actually work.

We should use accessKey instead.

Seems like a P5 (backlog).

Priority: -- → P5

Hi my name is Erik, and I would like to work on this bug. May I please be assigned to this issue? Thank you.

Hi! my name is Divya and I want to apply as an Outreachy intern. Can you please assign this issue to me?

(In reply to :Gijs (he/him) from comment #0)

https://searchfox.org/mozilla-central/rev/92d11a33250a8e368c8ca3e962e15ca67117f765/browser/base/content/browser.js#1572

The access key property has a capital K, and so this setting of it doesn't actually work.

Hi my name is Erik, and I would like to work on this bug. May I please be assigned to this issue? Thank you.

Hi,

I want to get started with contributing to Firefox, and I think this would be a great bug to start with!

Would it be possible to have it assigned to me?

(In reply to Erik Carrillo [:E_Carr] from comment #4)

Hi my name is Erik, and I would like to work on this bug. May I please be assigned to this issue? Thank you.

You're assigned to 6 open bugs, so I don't think you need to take this one, too.

(In reply to Divya Baid from comment #3)

Hi! my name is Divya and I want to apply as an Outreachy intern. Can you please assign this issue to me?

You were assigned to bug 1422665 a week ago and there's no patch on there - I'm assuming you're still working on that. If you're stuck, ask for help in that bug, don't just look for other stuff to work on.

(In reply to Atharva Gokhale from comment #5)

I want to get started with contributing to Firefox, and I think this would be a great bug to start with!

Great!

Would it be possible to have it assigned to me?

We normally assign bugs when people attach a patch.

(In reply to :Gijs (he/him) from comment #6)

(In reply to Erik Carrillo [:E_Carr] from comment #4)

Hi my name is Erik, and I would like to work on this bug. May I please be assigned to this issue? Thank you.

You're assigned to 6 open bugs, so I don't think you need to take this one, too.

Hello again :Gijs, 2 of the bugs I was assigned were showing the status of published when I originally asked to be assigned this bug. In fact, after your response I received the email notification that they had been resolved.

Bug 1531959 has also been approved and is awaiting to land tonight. I went ahead and submitted my patch to be considered eligible to be assigned this bug. Thanks.

(In reply to Karan Sapolia from comment #9)

Created attachment 9048756 [details]
Bug 1532673 - "Stop using safe mode" help access key funtionality restored. r=Gijs

Depends on D22246

Hello Gijs, I am a Outreachy applicant. Would like to take up this issue. I have also submitted a patch for it. Thanks.

As I see that E_Carr's other patch has been accepted and they are also assigned to other bugs, I would request Gijs and E_Carr to allow me to submit the patch here. This would be my first patch if accepted. Thank you.

Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/257a060b7d65
"Stop using safe mode" help access key funtionality restored. r=Gijs

(In reply to Erik Carrillo [:E_Carr] from comment #8)

(In reply to :Gijs (he/him) from comment #6)

(In reply to Erik Carrillo [:E_Carr] from comment #4)

Hi my name is Erik, and I would like to work on this bug. May I please be assigned to this issue? Thank you.

You're assigned to 6 open bugs, so I don't think you need to take this one, too.

Hello again :Gijs, 2 of the bugs I was assigned were showing the status of published when I originally asked to be assigned this bug. In fact, after your response I received the email notification that they had been resolved.

Bug 1531959 has also been approved and is awaiting to land tonight. I went ahead and submitted my patch to be considered eligible to be assigned this bug.

FWIW, I found this pretty rude. I explicitly suggested you worked on your other bugs. You've still got 4 other open bugs assigned to you, without attached patches. We explicitly have mentored and good-first-bugs to allow new folks to proverbially get their feet wet and get used to submitting patches. To stick with the metaphor, your feet are already wet. Please consider giving other people a chance. There's lots of other, harder bugs around now that you know how things work. If you're intending to apply to gsoc or outreachy, please focus on bugs actually related to the project you're hoping to work on.

(In reply to Karan Sapolia from comment #10)

Hello Gijs, I am a Outreachy applicant. Would like to take up this issue. I have also submitted a patch for it. Thanks.

Thanks, I've approved and landed your patch.

Assignee: nobody → sapoliakaran
Status: NEW → ASSIGNED
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 67
You need to log in before you can comment on or make changes to this bug.