Android builds do not produce target.gtest.tests.tar.gz
Categories
(Firefox Build System :: General, enhancement)
Tracking
(firefox68 fixed)
| Tracking | Status | |
|---|---|---|
| firefox68 | --- | fixed |
People
(Reporter: gbrown, Assigned: gbrown)
References
Details
Attachments
(1 file)
Linux (and other desktop) builds produce target.gtest.tests.tar.gz, but Android builds do not.
(That makes sense because gtest doesn't run on Android currently...but now we want to.)
|
Assignee | |
Comment 1•5 years ago
|
||
Android:
[task 2019-03-05T10:31:16.447Z] 10:31:16 INFO - package-tests> /builds/worker/workspace/build/src/obj-firefox/_virtualenvs/init/bin/python /builds/worker/workspace/build/src/build/gen_test_packages_manifest.py
[task 2019-03-05T10:31:16.447Z] 10:31:16 INFO - package-tests> --jsshell target.jsshell.zip
[task 2019-03-05T10:31:16.447Z] 10:31:16 INFO - package-tests> --dest-file 'dist//target.test_packages.json'
[task 2019-03-05T10:31:16.447Z] 10:31:16 INFO - package-tests> --common 'target.common.tests.zip'
[task 2019-03-05T10:31:16.447Z] 10:31:16 INFO - package-tests> --common 'target.common.tests.tar.gz' --cppunittest 'target.cppunittest.tests.tar.gz' --mochitest 'target.mochitest.tests.tar.gz' --reftest 'target.reftest.tests.tar.gz' --talos 'target.talos.tests.tar.gz' --raptor 'target.raptor.tests.tar.gz' --awsy 'target.awsy.tests.tar.gz' --xpcshell 'target.xpcshell.tests.tar.gz' --web-platform 'target.web-platform.tests.tar.gz' --updater-dep 'target.updater-dep.tests.tar.gz'
Linux:
[task 2019-03-05T10:01:14.984Z] 10:01:14 INFO - package-tests> /builds/worker/workspace/build/src/obj-firefox/_virtualenvs/init/bin/python /builds/worker/workspace/build/src/build/gen_test_packages_manifest.py
[task 2019-03-05T10:01:14.984Z] 10:01:14 INFO - package-tests> --jsshell target.jsshell.zip
[task 2019-03-05T10:01:14.984Z] 10:01:14 INFO - package-tests> --dest-file 'dist//target.test_packages.json'
[task 2019-03-05T10:01:14.984Z] 10:01:14 INFO - package-tests> --common 'target.common.tests.zip'
[task 2019-03-05T10:01:14.984Z] 10:01:14 INFO - package-tests> --common 'target.common.tests.tar.gz' --cppunittest 'target.cppunittest.tests.tar.gz' --mochitest 'target.mochitest.tests.tar.gz' --reftest 'target.reftest.tests.tar.gz' --talos 'target.talos.tests.tar.gz' --raptor 'target.raptor.tests.tar.gz' --awsy 'target.awsy.tests.tar.gz' --xpcshell 'target.xpcshell.tests.tar.gz' --web-platform 'target.web-platform.tests.tar.gz' --updater-dep 'target.updater-dep.tests.tar.gz' --gtest 'target.gtest.tests.tar.gz'
I suppose gtest is missing from TEST_PKGS_TARGZ because !LINK_GTEST_DURING_COMPILE
|
|
Assignee | |
Comment 2•5 years ago
|
||
...because of the 'browser' condition here
|
|
Assignee | |
Comment 3•5 years ago
|
||
Verified that issue here and successfully generated target.gtests.tar.gz for android:
|
|
Assignee | |
Comment 4•5 years ago
|
||
Try artifact builds still don't build target.gtests.tar.gz; I think that's expected.
|
|
Assignee | |
Comment 5•5 years ago
|
||
Pushed by gbrown@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b1571c522183 Include target.gtest.tests.tar.gz in android builds; r=bc
|
||
Comment 7•5 years ago
|
||
Backed out changeset b1571c522183 (bug 1532695) for causing gtest/TestMozURL.cpp build busatges
push that caused the backout: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&selectedJob=238900891&revision=b1571c5221831c10d481fec95bdb889bfd32e7b4
backout: https://hg.mozilla.org/integration/autoland/rev/7aa54b22f3aa2382596021a8e9c2dae3643202d1
|
|
Assignee | |
Comment 8•5 years ago
|
||
Sorry, I forgot that I need to land the first patch from bug 1318091 first.
Pushed by gbrown@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9eb55c9bf557 Include target.gtest.tests.tar.gz in android builds; r=bc
|
||
Comment 10•5 years ago
|
||
| bugherder | ||
|
||
Updated•5 years ago
|
Description
•