Closed Bug 1532711 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 15635 - [Animation Worklet] Deflake scroll-timeline-writing-mode test

Categories

(Testing :: web-platform-tests, enhancement, P4)

Product:
Testing
Component:
web-platform-tests
Type:
enhancement

Tracking

(firefox68 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla68
Tracking Flags:
Tracking Status
firefox68 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 15635 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/15635
Details from upstream follow.

Majid Valipour <majidvp@chromium.org> wrote:

[Animation Worklet] Deflake scroll-timeline-writing-mode test

Two changes to help fix flakiness:

  • Wait explicitly on receiving localTimes instead of an arbitrary number
    of frames.
  • Do not set the local time if currentTime is NaN. This deals with cases
    where timeline may not be immediately active (e.g., scroller is not
    activated in compositor.

The combination of the above deflakes this test.

Bug: 915352, 930462
Change-Id: I374b10c4221cfc7f1bb70e0c8977ab7d3365903b
Reviewed-on: https://chromium-review.googlesource.com/1497373
WPT-Export-Revision: 9381c5cf69cdf0ee6cbfb00e13f71704b6bfae1a

Ran 13 tests and 10 subtests
OK     : 3
FAIL   : 9
TIMEOUT: 9
ERROR  : 2
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d8992f33bd00
[wpt PR 15635] - [Animation Worklet] Deflake scroll-timeline-writing-mode test, a=testonly

https://hg.mozilla.org/mozilla-central/rev/d8992f33bd00

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox68: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in before you can comment on or make changes to this bug.