Remove unnecessary ESLint disabling mozilla/no-cpows-in-tests comments

RESOLVED FIXED in Firefox 68

Status

enhancement
RESOLVED FIXED
3 months ago
3 months ago

People

(Reporter: standard8, Assigned: mihir17166, Mentored)

Tracking

({good-first-bug})

Trunk
mozilla68

Firefox Tracking Flags

(firefox68 fixed)

Details

(Whiteboard: [lang=js])

Attachments

(1 attachment)

Reporter

Description

3 months ago

We removed the mozilla/no-cpows-in-tests rule a while ago, so we no longer need the ESLint comments where this rule was specifically disabled.

https://searchfox.org/mozilla-central/search?q=no-cpows-in-tests&case=false&regexp=false&path=

To help Mozilla out with this bug, here's the steps:

  1. Comment here on the bug that you want to volunteer to help. I (or someone else) will assign it to you.
  2. Download the Firefox source code, see the docs for details.
    • If you have any problems, please ask on IRC in the #introduction channel. They're there to help you get started.
    • You can also read the Developer Guide, which has answers to most development questions.
  3. Start working on this bug
    • You need to remove the references to mozilla/no-cpows-in-tests from the code (see the link above).
    • If the comment references more than just one rule, remove just the rule, otherwise remove the entire comment.
    • Commit the changes with a command such as hg commit -m "Bug nnn - Remove unnecessary ESLint disabling mozilla/no-cpows-in-tests comments. r?Standard8"
    • Once you're done, post the commits via phabricator. Please use moz-phab to submit them.
  4. Once the patches are submitted, I'll take a look. If there's any changes necessary I'll comment in Phabricator, so be prepared to update the patches.
  5. Once we're happy with the changes, I'll push it to autoland - our integration branch. Your code will then soon be shipping to Firefox users worldwide!
  6. Now you get to think about what kind of bug you'd like to work on next. Let me know what you're interested in and I can help you find your next contribution.
Assignee

Comment 1

3 months ago

I would be happy to volunteer to fix this bug.

Reporter

Comment 2

3 months ago

(In reply to mihir17166 from comment #1)

I would be happy to volunteer to fix this bug.

Hi, I've assigned it to you, please start working on it, and feel free to ask if you have questions.

Assignee: nobody → mihir17166

Comment 4

3 months ago
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5df0da0ce027
Remove unnecessary ESLint disabling mozilla/no-cpows-in-tests comments. r=Standard8

Comment 5

3 months ago
bugherder
Status: NEW → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in before you can comment on or make changes to this bug.