Tidy allocation function names

RESOLVED FIXED in Firefox 67

Status

()

enhancement
P3
normal
RESOLVED FIXED
3 months ago
2 months ago

People

(Reporter: jonco, Assigned: jonco)

Tracking

Trunk
mozilla67
Points:
---

Firefox Tracking Flags

(firefox67 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

3 months ago

I was confused by the different versions of Allocate() for objects/strings/other things which all templated on the thing type all take different sets of arguments so I tried to clean this up.

Assignee

Comment 1

3 months ago

This patch attempts to make things clearer by renaming the functions used for allocating objects and strings to AllocateObject and AllocateString, rather than having everything be called Allocate. Allocate is still used for atoms though which is a little strange but was hard to change.

Comment 2

3 months ago
Pushed by jcoppeard@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b8137cbaf9cf
Tidy allocation functions by renaming overloads for object and string allocation r=sfink

Comment 3

3 months ago
bugherder
Status: NEW → RESOLVED
Last Resolved: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
Depends on: 1534118
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Target Milestone: mozilla67 → ---

Comment 5

2 months ago
Pushed by apavel@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d45e5b4b57b9
Tidy allocation functions by renaming overloads for object and string allocation r=sfink
No longer depends on: 1534118

Comment 6

2 months ago
bugherder
Status: REOPENED → RESOLVED
Last Resolved: 3 months ago2 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.