Closed Bug 1532950 Opened 9 months ago Closed 9 months ago

NO_REASON is not a reason to GC

Categories

(Core :: JavaScript: GC, defect, P3)

Product:
Core
Component:
JavaScript: GC
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla68
Tracking Flags:
Tracking Status
firefox68 --- fixed

People

(Reporter: jonco, Assigned: jonco)

Details

Attachments

(1 file)

Bug 1532950 - Disallow NO_REASON as a reason to GC, and fix ExplainGCReason to handle it r=pbone!
47 bytes, text/x-phabricator-request
Details | Review

At the moment we allow NO_REASON as the GC reason which doesn't make sense and also breaks if we try to print it because ExplainGCReason doesn't handle it. Both of these things should be fixed.

Pushed by jcoppeard@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/144dfd01fb48
Disallow NO_REASON as a reason to GC, and fix ExplainGCReason to handle it r=pbone

https://hg.mozilla.org/mozilla-central/rev/144dfd01fb48

Status: NEW → RESOLVED
Closed: 9 months ago
status-firefox68: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in before you can comment on or make changes to this bug.