Closed Bug 153298 Opened 22 years ago Closed 22 years ago

Translate nsIAccessible events to ATK events

Categories

(Core :: XUL, defect)

x86
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: john.sun, Assigned: john.sun)

References

Details

Attachments

(1 file, 2 obsolete files)

 
Blocks: 145863
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
QA Contact: jrgm → mindy.liu
Attached patch preview version (obsolete) — Splinter Review
Only for preview.
waiting kyle to
1) add EVENT_VISIBLE_DATA_CHANGED into nsIAccessibleEventListern.idl
2) move those accessible event data definitions from nsRootAccessible.h to a
suitable file
John, It is very good.
Some comments:
1. many of local variables have names begin with "a". I think only parameters to
function definition should have such names.

You can change
+    AtkTableChange * aAtkTableChange;
...
+            MaiObject *aOldMaiObj, *aNewMaiObj; 
To:
+    AtkTableChange * atkTableChange;
...
+            MaiObject *oldMaiObj, *newMaiObj; 

2. Should be aAtkPropChange->newvalue in the code below.
                             ^^^^^^^
+            if (aAtkPropChange->oldvalue) 
+                aNewMaiObj = CreateMaiObjectFor(NS_REINTERPRET_CAST
+                                 (nsIAccessible *, aAtkPropChange->newvalue));
Attached patch v1 seeking review (obsolete) — Splinter Review
Aaron,
Could you pls review the patch? Thanks in advance.
Attachment #89899 - Attachment is obsolete: true
Mai does not need my r='s anymore. You can use anyone familiar with it now.
Bolian or Kyle can take the reviewing responsibility for MAI. Bolian, can you
take a look at it now? thanks.
Attached patch v2Splinter Review
Changes vs prior patch
a) adding translate function for a single state.
b) adding some code to enhance error tolerance.

Contained in internal build for test now.

Kyle, pls help to review it. THX.
Attachment #90287 - Attachment is obsolete: true
Comment on attachment 91930 [details] [diff] [review]
v2

passed internal test. please check it in.
r=kyle
Attachment #91930 - Flags: review+
kyle,
Could U pls help to checkin the patch? THX!
checked in!
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
Thanks!
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: