Closed Bug 1532988 Opened 9 months ago Closed 9 months ago

[Content Blocking] The icons of Fingerprinters and Cryptominers are missing from the Shield menu lists

Categories

(Firefox :: Protections UI, defect, P1)

Unspecified
All
defect

Tracking

()

VERIFIED FIXED
Firefox 67
Tracking Status
firefox-esr60 --- unaffected
firefox65 --- unaffected
firefox66 --- unaffected
firefox67 --- verified

People

(Reporter: david.olah, Assigned: johannh)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

[Affected versions]
latest Nightly 67.0a1

[Affected platforms]
Windows 10 x64
macOS 10.13
Ubuntu 16.04 x64

[Prerequisites]
Launch Firefox on a clean profile.
Set the following prefs to true in about:config

privacy.trackingprotection.cryptomining.enabled
privacy.trackingprotection.fingerprinting.enabled
browser.contentblocking.cryptomining.preferences.ui.enabled
browser.contentblocking.fingerprinting.preferences.ui.enabled

[Steps to reproduce]

  1. Go to Content Blocking Preferences page and check Fingerprinters and Cryptominers
  2. In a new tab, go to a page that contains Fingeprinters or Cryptominers(Ex: https://senglehardt.com/test/trackingprotection/test_pages/fingerprinting_and_cryptomining_and_trackers.html)
  3. Click the Shield icon
  4. Open the Cryptominers and Fingeprinters lists

[Expected result]
Fingerprinter and Cryptominer icons are shown for each found/blocked Fingerprinter and Cryptominer

[Actual result]
No Fingerprinter or Cryptominer icon is shown in the lists

[Note]
For Trackers and Cookies, the icon is present for each found/blocked Tracker and Cookie from the lists. [Check attachment] If a blockable element is found and not blocked, the specific icon should appear in normal state. If a blockable element is blocked, the specific icon should appear grayed out and crossed over - as for Trackers and Cookies.

I think your url classifier tables aren't up to date. Please try going to about:url-classifier, and clicking "Trigger Update" on the "mozilla" row under Provider, and try again.

The update was made manually, otherwise, the fingerprinters and the cryptominers would not be blocked and they are. The problem here is that the icons don't appear.

Good catch, should be easy to fix. Thanks!

Assignee: nobody → jhofmann
Status: NEW → ASSIGNED
Priority: -- → P1
Pushed by jhofmann@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d280b4e8d2a4
Fix fingerprinters and cryptominers sub-panel icon sizing. r=ewright
Status: ASSIGNED → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 67
Flags: qe-verify+

Confirmed the issue with 63.0a1 (2018-07-02) on Windows 10.
Fix verified with help of the provided addon with 68.0a1 (2019-04-17) on Windows 10, macOS 10.13, Ubuntu 16.04; after updating the url classifier tables.
Also, the icons are properly displayed in the info menu.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.