1532988 - [Content Blocking] The icons of Fingerprinters and Cryptominers are missing from the Shield menu lists

Status: VERIFIED FIXED

(Firefox :: Protections UI, defect, P1)

Description

[David Olah]

Attachment: bandicam 2019-03-06 15-52-59-463.mp4

[Affected versions]
latest Nightly 67.0a1

[Affected platforms]
Windows 10 x64
macOS 10.13
Ubuntu 16.04 x64

[Prerequisites]
Launch Firefox on a clean profile.
Set the following prefs to true in about:config

privacy.trackingprotection.cryptomining.enabled
privacy.trackingprotection.fingerprinting.enabled
browser.contentblocking.cryptomining.preferences.ui.enabled
browser.contentblocking.fingerprinting.preferences.ui.enabled

[Steps to reproduce]

1. Go to Content Blocking Preferences page and check Fingerprinters and Cryptominers
2. In a new tab, go to a page that contains Fingeprinters or Cryptominers(Ex: https://senglehardt.com/test/trackingprotection/test_pages/fingerprinting_and_cryptomining_and_trackers.html)
3. Click the Shield icon
4. Open the Cryptominers and Fingeprinters lists

[Expected result]
Fingerprinter and Cryptominer icons are shown for each found/blocked Fingerprinter and Cryptominer

[Actual result]
No Fingerprinter or Cryptominer icon is shown in the lists

[Note]
For Trackers and Cookies, the icon is present for each found/blocked Tracker and Cookie from the lists. [Check attachment] If a blockable element is found and not blocked, the specific icon should appear in normal state. If a blockable element is blocked, the specific icon should appear grayed out and crossed over - as for Trackers and Cookies.

Comment 1

[(no longer active)]

I think your url classifier tables aren't up to date. Please try going to about:url-classifier, and clicking "Trigger Update" on the "mozilla" row under Provider, and try again.

Comment 2

[David Olah]

The update was made manually, otherwise, the fingerprinters and the cryptominers would not be blocked and they are. The problem here is that the icons don't appear.

Comment 3

[Johann Hofmann [:johannh]]

Good catch, should be easy to fix. Thanks!

Comment 4

[Johann Hofmann [:johannh]]

Attachment: Bug 1532988 - Fix fingerprinters and cryptominers sub-panel icon sizing. r=ewright

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d280b4e8d2a4
Fix fingerprinters and cryptominers sub-panel icon sizing. r=ewright

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/d280b4e8d2a4

Comment 7

[Cristian Fogel [:cfogel]]

Confirmed the issue with 63.0a1 (2018-07-02) on Windows 10.
Fix verified with help of the provided addon with 68.0a1 (2019-04-17) on Windows 10, macOS 10.13, Ubuntu 16.04; after updating the url classifier tables.
Also, the icons are properly displayed in the info menu.