[skiplist] Add mozilla::HashMapEntry<T>::~HashMapEntry to skiplist
Categories
(Socorro :: Signature, task)
Tracking
(Not tracked)
People
(Reporter: marcia, Assigned: mccr8)
Details
Per Bug 1530364#c3, Andrew mentions that mozilla::HashMapEntry<T>::~HashMapEntry isn't a great signature and should be added to the skiplist. Adding Andrew in case he has any clarifications.
|
Assignee | |
Comment 1•6 years ago
|
||
Thanks for filing! Yeah, this is another stack frame that is more of a data structure thing than an actual interesting frame.
It might be good to add some other things, too. For instance, this crash has some other hash table stuff: bp-baf8df61-ae2a-4152-93a7-c2f510190305
Maybe some of this should be on the prefix list, even.
I suppose I can take a look into that.
|
||
Comment 2•6 years ago
|
||
Andrew: Want me to grab this one and do it today?
|
|
Assignee | |
Comment 3•6 years ago
|
||
No thanks. I'm just mulling it over. For the bug that actually inspired this, it is a slight step back, because you end up splitting it into multiple signatures, and there don't seem to be any other crashes at the moment in that bucket, so I think it isn't urgent.
|
|
Assignee | |
Comment 4•6 years ago
|
||
There's 3 varieties of proto signatures I found:
- mozilla::HashMapEntry<T>::~HashMapEntry | mozilla::detail::HashTable<T>::destroyTable | XPCWrappedNativeScope::~XPCWrappedNativeScope bp-065e30d0-3d3f-4b3c-bc9b-326fc0190301
- mozilla::HashMapEntry<T>::~HashMapEntry | <name omitted> | XPCWrappedNativeScope::~XPCWrappedNativeScope bp-bb845d5b-bd95-44a7-bc23-96d3a0190305
- mozilla::HashMapEntry<T>::~HashMapEntry | mozilla::detail::HashTable<T>::destroyTable | js::WeakMap<T>::~WeakMap | JS::WeakMapPtr<T>::destroy | XPCWrappedNativeScope::~XPCWrappedNativeScope bp-1862e857-b1be-412d-aaa7-d03430190305
<name omitted> is on the skip list. I think it makes sense to add mozilla::detail::HashTable<T>::destroyTable if I'm going to add the ~HashMapEntry. Maybe it also makes sense to add js::WeakMap<T>::~WeakMap and JS::WeakMapPtr<T>::destroy. I guess I could search for proto signatures that contain those frames.
|
|
Assignee | |
Comment 5•6 years ago
|
||
Looks like destroyTable is already on the prefix list, so never mind about that.
|
|
Assignee | |
Comment 6•6 years ago
|
||
I think I'm just going to close this. There's no other crashes with this signature AFAICT, and it would just end up splitting a single crash signature into multiple. Maybe in the future there would be some value.
Description
•