Can't see a (blocking) review request on a revision in Active Revisions
Categories
(Conduit :: Phabricator, defect)
Tracking
(Not tracked)
People
(Reporter: mayhemer, Assigned: dkl)
Details
See https://phabricator.services.mozilla.com/D22110 which is blocked on my (mayhemer) review. But when I go to https://phabricator.services.mozilla.com/differential/ -> Active Revisions logged in under that account, I can't see that request listed.
Are there two 'mayhemer' accounts? Or is this a phab bug?
Note that the same bug has two patches (revisions) awaiting my review. The P3 bug is visible, the P1 is not. But I always was able to see requests from all revisions on a single bug.
This could easily make me totally overlook a priority review request! -> major.
Please try to look at this ASAP as I can't block the patch for long.
|
Assignee | |
Updated•6 years ago
|
|
Reporter | |
Comment 1•6 years ago
|
||
Hell! Power of habit.. I just r-'ed the patch :(
|
|
Assignee | |
Comment 2•6 years ago
|
||
I do not see two mayhemer accounts. I do see another account with the full name containing Honza which could cause confusion I guess when looking for a reviewer. But in this case you were added correctly. I do not see where you were added as a blocking reviewer. It looks like you were just added as a normal reviewer. When a person is a normal reviewer, the revision will not show up in your active revisions list if the revisions has been either accepted or changes have been requested since then it is no longer considered to be on your action list. If you are a real blocking reviewer then it will display on your list til you do something with it. So this is by design currently.
|
|
Reporter | |
Comment 3•6 years ago
|
||
(In reply to David Lawrence [:dkl] from comment #2)
Sorry, as per comment 1 I simply forgot to keep that revision open for you to examine :/ Muscle memory just added the action and pressed submit.
When a person is a normal reviewer, the revision will not show up in your active revisions list if the revisions has been either accepted or changes have been requested since then
That happened, yes. There were another reviewer that already requested changes. But the icon side by my nick in the revision was the red circle (indication of a blocking request?)
it is no longer considered to be on your action list. If you are a real blocking reviewer then it will display on your list til you do something with it. So this is by design currently.
Hm.. ok, I'll watch it. Thanks and sorry one last time:)
Description
•