1533048 - Improve error messages when parsing wpt manifests fails

Status: RESOLVED FIXED

(Testing :: web-platform-tests, defect)

Description

[James Graham [:jgraham]]

The error messages often aren't very good and in particular don't always tell you which file has the problem, which makes debugging rather complex.

Comment 1

[James Graham [:jgraham]]

Attachment: Bug 1533048 - Improve wpt expectation ini error messages,

Currently we don't always give a useful message and in particular don't always include
the file and line number of the place where the exception occured in order to give a
clue about where the error might be.

To fix this, if we get an error that isn't a ParseError, wrap it in a ParseError to give the
file and line. Also improve one error message.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:jgraham, could you have a look please?

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4b13ce92cd30
Improve wpt expectation ini error messages, r=ato

Comment 4

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/18176 for changes under testing/web-platform/tests

Comment 5

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

Comment 6

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/4b13ce92cd30

Comment 7

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR merged