Port keyboard navigation test from autocomplete
Categories
(Firefox :: Address Bar, enhancement, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox68 | --- | fixed |
People
(Reporter: mak, Assigned: adw)
References
Details
(Whiteboard: [fxsearch])
Attachments
(1 file)
This test has a few keyboard navigation actions, we should evaluate whether current coverage is enough, or we want to do additional navigation testing.
https://searchfox.org/mozilla-central/source/toolkit/content/tests/chrome/test_autocomplete4.xul
|
Assignee | |
Updated•5 years ago
|
|
Reporter | |
Updated•5 years ago
|
|
|
Assignee | |
Comment 1•5 years ago
|
||
I don't think we need to port this test per se. It checks:
- The home key moves the caret to the beginning of the input
- Left arrow key moves the caret one char to the left
- Right arrow key keeps the caret where it is when the caret is at the end
- Enter key removes selection
- Tab key completes selected index when forcecomplete is set
- Right key completes selected index in a couple of cases
The first three are such basic textbox behaviors that we wouldn't expect the urlbar to break them. The last three are autocomplete-specific and don't apply to the quantumbar and afaict not even to the awesomebar. Overall, it looks like this test is specifically checking this behavior here: https://searchfox.org/mozilla-central/rev/44a212460990ffffecf50a8e972d3cbde2e7216b/toolkit/components/autocomplete/nsAutoCompleteController.cpp#547 And none of that applies to quantumbar.
However, we don't have urlbar tests for tab and page-up/down, or specifically for up/down. iow the up/down, page-up/down, and tab parts of this code here: https://searchfox.org/mozilla-central/rev/44a212460990ffffecf50a8e972d3cbde2e7216b/browser/components/urlbar/UrlbarController.jsm#265
So I'd like to add tests for that.
|
|
Assignee | |
Comment 2•5 years ago
|
||
|
|
Assignee | |
Comment 3•5 years ago
|
||
| Comment hidden (obsolete) |
|
|
Assignee | |
Comment 5•5 years ago
|
||
Actual try verify: https://treeherder.mozilla.org/#/jobs?repo=try&revision=8da01d4be4b8a6fccba0e1ba037846fff5765e48
Looks good so far. The TVw tests are web-platform tests that of course don't contain my mochitest, so that's why they're failing.
Pushed by dwillcoxon@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/eb068229a2d5 Add tests for selection key navigation: up/down, page-up/down, tab r=mak
|
||
Comment 7•5 years ago
|
||
| bugherder | ||
Description
•