1533179 - --enable-gc-trace doesn't build

Status: RESOLVED DUPLICATE of bug 1386298

(Core :: JavaScript: GC, defect, P3)

Description

[Matthew Gaudet (he/him) [:mgaudet]]

STR:

../configure --enable-gc-trace && make 

Expected:

Build Succeeds

Actual:

In file included from /Users/mgaudet/unified2/js/src/build_trace_DBG.OBJ/js/src/gc/Unified_cpp_js_src_gc0.cpp:38:                                                                                                       
/Users/mgaudet/unified2/js/src/gc/GCTrace.cpp:27:1: error: static_assert failed "JS_STATIC_ASSERT"
JS_STATIC_ASSERT(NumAllocKinds == unsigned(AllocKind::LIMIT));
^                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/Users/mgaudet/unified2/js/src/build_trace_DBG.OBJ/dist/include/js/Utility.h:39:32: note: expanded from macro 'JS_STATIC_ASSERT'
#define JS_STATIC_ASSERT(cond) static_assert(cond, "JS_STATIC_ASSERT")
                               ^             ~~~~
In file included from /Users/mgaudet/unified2/js/src/build_trace_DBG.OBJ/js/src/gc/Unified_cpp_js_src_gc0.cpp:38:
/Users/mgaudet/unified2/js/src/gc/GCTrace.cpp:79:22: error: no member named 'init' in 'mozilla::HashSet<const js::Class *, mozilla::DefaultHasher<const js::Class *>, js::SystemAllocPolicy>'
  if (!tracedClasses.init() || !tracedGroups.init()) {
       ~~~~~~~~~~~~~ ^
/Users/mgaudet/unified2/js/src/gc/GCTrace.cpp:79:46: error: no member named 'init' in 'mozilla::HashSet<const js::ObjectGroup *, mozilla::DefaultHasher<const js::ObjectGroup *>, js::SystemAllocPolicy>'
  if (!tracedClasses.init() || !tracedGroups.init()) {
                                ~~~~~~~~~~~~ ^
/Users/mgaudet/unified2/js/src/gc/GCTrace.cpp:105:17: error: no member named 'finish' in 'mozilla::HashSet<const js::Class *, mozilla::DefaultHasher<const js::Class *>, js::SystemAllocPolicy>'
  tracedClasses.finish();
  ~~~~~~~~~~~~~ ^
/Users/mgaudet/unified2/js/src/gc/GCTrace.cpp:106:16: error: no member named 'finish' in 'mozilla::HashSet<const js::ObjectGroup *, mozilla::DefaultHasher<const js::ObjectGroup *>, js::SystemAllocPolicy>'
  tracedGroups.finish();
  ~~~~~~~~~~~~ ^

Comment 1

[Jon Coppeard (:jonco)]

I was considering removing this feature in bug 1386298 but someone said they might find it useful (I forget who). Maybe we can remove it now though.

Comment 2

[Matthew Gaudet (he/him) [:mgaudet]]

I think keeping the hook points & automatic disablement of the JIT allocation fastpaths would be valuable;

In that world it could be renamed to GC Probes?

I found this to be particularly useful for finding when a particular thing happened in the GC.

Comment 3

[Jon Coppeard (:jonco)]

Fixed by the changes in bug 1386298.