1533217 - browser.tabs.usecache isn't enabled by default on Fennec Nightly

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P1)

Description

[csheany]

User Agent: Mozilla/5.0 (Android 7.1.1; Tablet; rv:67.0) Gecko/67.0 Firefox/67.0

Steps to reproduce:

1. Open about:config
2. Search for the pref

Actual results:

The value is false

Expected results:

To be determined

Comment 2

[csheany]

Thank you.

If there aren't any problems, does it require enabling any other prefs?

Comment 3

[Jan Henning [:JanH]]

No, that pref is enough if you want to enable this for yourself in Release.

Comment 4

[csheany]

Don't you mean Nightly :)

Comment 5

[Jan Henning [:JanH]]

No, it should be turned on everywhere except Release, but I guess something could have gone awry with the Switchboard config...

Comment 6

[csheany]

I just meant that is what I am using but it is still off.

Comment 7

[csheany]

Reopen?

Comment 8

[Jan Henning [:JanH]]

Who controls Switchboard these days? While at a first glance the appId configuration for "offline-cache" looks reasonable (^org.mozilla.fennec|org.mozilla.firefox_beta), I've noticed that the other two Nightly/Beta-only experiments use ^org.mozilla.fennec.*$|^org.mozilla.firefox_beta$. Given the fact that Nightly has been org.mozilla.fennec_aurora for some time now, the latter regex would indeed be the correct choice.

Comment 9

[csheany]

Is he still around?

Isn't triage now with :stefan?

FWIW, it has been working well.

Does it have an affect on online perormance?

Comment 10

[Jan Henning [:JanH]]

Is he still around?

You're right, yes.
No, this is solely about attempting to load pages from the cache when offline.

Comment 11

[Liz Henry (:lizzard) (relman/hg->git project)]

Barbara, do you know who controls Switchboard? Thanks.

Comment 12

[Petru-Mugurel Lingurar [:petru]]

We can take this.

Looked over the current implementation, indeed based on the current Switchboard config the "offline-cache" experiment would only be enabled by default on "org.mozilla.firefox_beta".
Based on the timestamp in the experiment last time the schema was changed was in December 2016. Not sure why.
Will investigate for the initial configuration and the change reason.

Comment 13

[csheany]

Thanks Petru :)

Comment 14

[Jan Henning [:JanH]]

The last change that I know of should have been in mid-2017 due to bug 1373756, after a failed attempt to enable it for everybody.

Comment 15

[Petru-Mugurel Lingurar [:petru]]

Thanks Jan. Sorry for the delay in responding.
Looked over this a bit more, curios if the functionality could be enabled also for Release as it looks like this was the initial plan - bug 1236130 comment 64 and it could be a cool feature but then I saw this meta - bug 1232867 with quite a few tickets still to be addressed.
Will have it enabled for dev/nightly/beta builds.

Comment 16

[Petru-Mugurel Lingurar [:petru]]

offline-cache is now enabled by default on all builds but release - https://firefox.settings.services.mozilla.com/v1/buckets/fennec/collections/experiments/records

Comment 17

[Stefan Deiac]

Verified as fixed on Nightly 68.0a1 (2019-05-07) and Beta 67.0b18 using OnePlus 5T (Android 9) and Nexus 5 (Android 6.0.1).