1533220 - Enable AudioIPC builds on Windows aarch64

Status: VERIFIED FIXED

(Core :: Audio/Video: cubeb, enhancement, P2)

Description

[Matthew Gregan [:kinetik]]

Windows AudioIPC started landed in bug 1512445. Unfortunately, it is build time disabled on Windows aarch64 due to legacy winapi 0.2.x dependencies. See bug 1512445 comment 8 for more.

Comment 1

[lukas.bernhard]

FWIW: the 2 projects linked in the above comment use winapi 0.3 since a while.

Comment 2

[Matthew Gregan [:kinetik]]

Attachment: Bug 1533220 - Enable AudioIPC on Windows arm64. r?#cubeb-reviewers

Depends on D134931

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6ea529a8a1ab
Enable AudioIPC on Windows arm64.  r=cubeb-reviewers,padenot

Comment 4

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/6ea529a8a1ab

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Does this need manual QA? Note that we're not running any Windows ARM64 tests in CI anymore.

Comment 6

[Matthew Gregan [:kinetik]]

I've done some manual testing locally on a Surface Pro X (SQ1), with everything (audio related) working as expected. More testing would be appreciated if resources permit, though.

Comment 7

[Anca Soncutean, Desktop QA]

Do we need to test something specific or some sanity/exploratory testing around basic audio functionality on top sites, maybe including some WebRTC coverage is enough? Thank you!

Comment 8

[Matthew Gregan [:kinetik]]

Just sanity/basic audio testing would be enough I think, thanks!

Comment 9

[Anca Soncutean, Desktop QA]

I've run an audio sanity check on RC 113 with Windows 10 ARM. I've used several popular websites providing media content (youtube, facebook, netflix, twich, spotify, tunein, hypem), a WebRTC call (jitsi meet) and several different audio format (MP3, OGG, FLAC, ACC). I didn't encountered any issue, therefore, I will mark this work as verified fixed.