Closed Bug 1533263 Opened 7 months ago Closed 7 months ago

Network:Proxy Cannot set custom DNS-over-HTTPS URI

Categories

(Firefox :: Preferences, defect, P3)

defect

Tracking

()

VERIFIED FIXED
Firefox 68
Tracking Status
firefox66 --- wontfix
firefox67 --- verified
firefox68 --- verified

People

(Reporter: qokelate, Assigned: sfoster)

References

Details

Attachments

(2 files)

Attached image WX20190307-152316.png

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:66.0) Gecko/20100101 Firefox/66.0

Steps to reproduce:

  1. settings/network enable DNS-over-HTTPS
  2. set custom https uri, commit
  3. reopen network, DNS-over-HTTPS is enabled, but custom uri cannot change(need re-enable DNS-over-HTTPS)

Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:67.0) Gecko/20100101 Firefox/67.0
20190306161300

Alternate STR:

  1. Check "Enable DNS over HTTPS" ("Use default" gets selected by default)
  2. Click the OK button.
  3. Click the Settings… button.

AR
"Custom" is disabled and cannot be selected.

ER
It should be possible to switch to a custom URL.

Blocks: 1482271
Status: UNCONFIRMED → NEW
Component: Untriaged → Preferences
Ever confirmed: true
Flags: needinfo?(daniel)
Flags: needinfo?(daniel) → needinfo?(sfoster)
Priority: -- → P3
Version: 66 Branch → Trunk

I think I see what's going on here. initDnsOverHttpsUI is getting called in a DOMContentLoaded event handler. It enables/disables fields based on the .checked property of elements bound to pref values. But those elements are updated with the current pref value in a promise that resolves after DOMContentLoaded.

I have a patch in progress.

Assignee: nobody → sfoster
Flags: needinfo?(sfoster)

(In reply to Sam Foster [:sfoster] (he/him) from comment #3)

Created attachment 9050056 [details]
Bug 1533263 - wait for initial pref values before init-ing the DNS-Over-HTTPs UI

:jaws, this patch has a fix for the problem, but its kinda janky. We end up with this arbitrary-looking promise/tick and I would expect more races in the tests which also assume the UI is ready once the sub-dialog is loaded. Is there some event or better signal I can use here?

Flags: needinfo?(jaws)

Discussed over IRC to try to either wait for syncfrompreference or wait until the preference elements are updated instead of using the Promise.resolve tick.

Flags: needinfo?(jaws)
Attachment #9050056 - Attachment description: Bug 1533263 - wait for initial pref values before init-ing the DNS-Over-HTTPs UI → Bug 1533263 - wait for initial pref values before init-ing the DNS-Over-HTTPs UI. r?Jaws
Pushed by sfoster@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5b79e86736f4
wait for initial pref values before init-ing the DNS-Over-HTTPs UI. r=jaws
Status: NEW → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 68

P3 and we are at out mid-point on beta, wontfix for 67

(In reply to Pascal Chevrel:pascalc from comment #8)

P3 and we are at out mid-point on beta, wontfix for 67

Gah, I was just going to request uplift today. This is a low-risk patch, can I make a case for it :pascalc?

Flags: needinfo?(pascalc)

(In reply to Sam Foster [:sfoster] (he/him) from comment #9)

(In reply to Pascal Chevrel:pascalc from comment #8)

P3 and we are at out mid-point on beta, wontfix for 67

Gah, I was just going to request uplift today. This is a low-risk patch, can I make a case for it :pascalc?

You can :)

Flags: needinfo?(pascalc)

Comment on attachment 9050056 [details]
Bug 1533263 - wait for initial pref values before init-ing the DNS-Over-HTTPs UI. r?Jaws

Beta/Release Uplift Approval Request

  • Feature/Bug causing the regression: Bug 1482271
  • User impact if declined: Users will be unable to use the Preferences UI to change the custom URI for DNS over HTTPs once set
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): The patch well contained to the network panel of the preferences UI. Its all front-end code and just defers the initialization of that UI with no new logic.
  • String changes made/needed: None
Attachment #9050056 - Flags: approval-mozilla-beta?
Flags: qe-verify+

Comment on attachment 9050056 [details]
Bug 1533263 - wait for initial pref values before init-ing the DNS-Over-HTTPs UI. r?Jaws

Patch looks low risk and has tests, I'd like QA to verify it on Nightly before uplifting to beta, thanks.

I have reproduced this issue using Firefox 68.0a1 on Win 10 x64.
I can confirm this issue is fixed on Nightly, I verified using Firefox 68.0a1 on Win 10 x64, macOS 10.14.3 and Ubuntu 18.04 x64.

Comment on attachment 9050056 [details]
Bug 1533263 - wait for initial pref values before init-ing the DNS-Over-HTTPs UI. r?Jaws

Low risk, verified on Nightly by QA, has tests, uplift approved for 67 beta 10, thanks.

Attachment #9050056 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
QA Whiteboard: [qa-triaged]

I can confirm this issue is fixed, I verified using Firefox 67.0b10 on Win 10 x64, macOS 10.14.3 and Ubuntu 18.04 x64.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.