Shader compile failure did not fallback to compositor rendering on android

RESOLVED FIXED in Firefox 69

Status

()

Product:
Core
Component:
Graphics: WebRender
Type:
defect
Importance:
P3
normal
Status:
RESOLVED FIXED
Opened:
5 months ago
Updated:
Last month

People

(Reporter: sotaro, Assigned: sotaro)

Tracking

(Blocks 1 bug)

Version:
unspecified
Target:
mozilla69
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox69 fixed)

Details

Attachments

(1 attachment, 2 obsolete attachments)

Bug 1533296 - Make WebRender error as to Fallback to Compositor rendering during disabling WebRender on android
47 bytes, text/x-phabricator-request
Details | Review

When shader compile failure happened by Bug 1532245, it just stop rendering. It did not cause gecko to fallback to compositor rendering.

Blocks: wr-android
Summary: Shader compile failure did not fallback to normal compositor on android → Shader compile failure did not fallback to compositor rendering on android
Priority: -- → P3
Assignee: nobody → sotaro.ikeda.g

On android, nsWindow creates LayerManager and CompositorSession only once. We need to add re-creating LayerManager and CompositorSession during disabling WebRender.

Posted patch wip (obsolete) — — Splinter Review
Depends on: 1529870
Posted patch wip (obsolete) — — Splinter Review
Attachment #9054130 - Attachment is obsolete: true
Attachment #9056457 - Attachment is obsolete: true
Depends on: 1543560
Pushed by sikeda@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/548576be041b
Make WebRender error as to Fallback to Compositor rendering during disabling WebRender on android r=nical

https://hg.mozilla.org/mozilla-central/rev/548576be041b

Status: NEW → RESOLVED
Closed: Last month
status-firefox69: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
You need to log in before you can comment on or make changes to this bug.