1533365 - On tablets the icon from Sync page its not displayed correctly

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Theme and Visual Design, defect, P2)

Description

[Eliza Balazs]

Attachment: Screenshot_20190307-143750_Gallery.jpg

Environment:
Device:

• Samsung Galaxy Tab S3 (Android 8);
• Google Pixel XL (Android P).

Build:

• Nightly 67.0a1 (2019-03-06);
• Beta 66.0b13
• Release 65.0.1

Steps to reproduce:

1. Go to Menu -> Setting -> General -> Sign in;
2. Observe the icon from the new opened Firefox Sync tab.

Expected result:
The tab icon is the Firefox logo.

Actual result:
The tab icon is a dark blue square with a white dot in the middle.

Notes:

• When typing about:account in the URL bar this is not reproducible;
• This is also reproducible when going to Menu -> Tools -> Logins or in Tab tray;
• Not reproducible on phones;
• Video: https://drive.google.com/file/d/1vRZu6dXUWU-rKw2mtrgBext5CFgi-3ig/view?usp=sharing

Comment 1

[Diana Iacos]

Attachment: Bug 1533365 - On tablets the icon from Sync page its not displayed correctly; r?petru

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9bcf8d612458
On tablets the icon from Sync page its not displayed correctly; r=petru

Comment 3

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/9bcf8d612458

Comment 4

[Pascal Chevrel:pascalc]

P2 and we shipped multiple releases with this bug, wontfix 67.

Comment 5

[Julien Cristau [:jcristau]]

I guess we'll want this uplifted to 68.

Comment 6

[Diana Iacos]

Comment on attachment 9066317 [details]
Bug 1533365 - On tablets the icon from Sync page its not displayed correctly; r?petru

Beta/Release Uplift Approval Request

• User impact if declined: If the uplift will be declined then the users will not be able to see correctly the favicon when they open “about:accounts” and “about:logins” links.

• Is this code covered by automated tests?: Yes

• Has the fix been verified in Nightly?: No

• Needs manual test from QE?: Yes

• If yes, steps to reproduce:

  Go to Menu -> Setting -> General -> Sign in;
  Observe the icon from the new opened Firefox Sync tab.

Expected result:
The tab icon is the Firefox logo.

Actual result:
The tab icon is a dark blue square with a white dot in the middle.

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Not risky as it is a small targeted code change.
• String changes made/needed:

Comment 7

[Julien Cristau [:jcristau]]

Comment on attachment 9066317 [details]
Bug 1533365 - On tablets the icon from Sync page its not displayed correctly; r?petru

approved for 68.0b5

Comment 8

[Oana Pop-Rus]

https://hg.mozilla.org/releases/mozilla-beta/rev/80259caee8e3

Comment 9

[Stefan Deiac]

Verified as fixed on the latest Nightly: 68.0a1 (2019-05-25) using Samsung Galaxy Tab S3 (Android 8).

Comment 10

[Diana Rus]

Hi,

Issue has been verified with pass status on device Lenovo TB3-850M with Android 6.0 and builds: Firefox Nightly 68.0a1 (2019-05-28) and Firefox Beta 68.0b5->the icon specific for each build is present in tab.

I also checked on Google Pixel C with Android 8.0.0 and builds: Firefox Nightly 68.0a1 (2019-05-28) and Firefox Beta 68.0b5->the icon specific for each build is present in tab.

I will mark the issue as resolved-verified.

Thanks,
Diana