Closed Bug 1533426 Opened 6 years ago Closed 6 years ago

browser/components/preferences/in-content/tests/siteData/browser_siteData2.js fails with LSNG enabled

Categories

(Core :: Storage: Quota Manager, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla67
Tracking Status
firefox67 --- fixed

People

(Reporter: janv, Assigned: janv)

References

Details

Attachments

(1 file)

The test simulates user's interaction with pref UI and once OK is hit the clearing starts to happen, but the test checks usage on disk immediately without waiting for clearing to finish.

Blocks: 1517090
Attached patch race-fixSplinter Review
Assignee: nobody → jvarga
Comment on attachment 9049225 [details] [diff] [review] race-fix Review of attachment 9049225 [details] [diff] [review]: ----------------------------------------------------------------- This is okay for me to unblock LSNG landing, but please file a follow-up (or leave this bug open) to actually fix the test issues.
Attachment #9049225 - Flags: review+
Pushed by jvarga@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/9dde4b9b46e2 browser/components/preferences/in-content/tests/siteData/browser_siteData2.js fails with LSNG enabled; r=johannh
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67

(In reply to Johann Hofmann [:johannh] from comment #2)

Comment on attachment 9049225 [details] [diff] [review]
race-fix

Review of attachment 9049225 [details] [diff] [review]:

This is okay for me to unblock LSNG landing, but please file a follow-up (or
leave this bug open) to actually fix the test issues.

Was this done?

Flags: needinfo?(jvarga)

Tom Tung is going to take a look at similar stuff in bug 1533681. He might investigate this bug after that.

Flags: needinfo?(jvarga)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: