browser/components/preferences/in-content/tests/siteData/browser_siteData2.js fails with LSNG enabled

RESOLVED FIXED in Firefox 67

Status

()

Product:
Core
Component:
DOM: Quota Manager
Type:
defect
Status:
RESOLVED FIXED
Opened:
5 months ago
Updated:
4 months ago

People

(Reporter: janv, Assigned: janv)

Tracking

(Depends on 1 bug)

Version:
Trunk
Target:
mozilla67
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox67 fixed)

Details

Attachments

(1 attachment)

race-fix
1.63 KB, patch
johannh
: review+
Details | Diff | Splinter Review

The test simulates user's interaction with pref UI and once OK is hit the clearing starts to happen, but the test checks usage on disk immediately without waiting for clearing to finish.

Blocks: 1517090
Posted patch race-fix — — Splinter Review
Assignee: nobody → jvarga
Comment on attachment 9049225 [details] [diff] [review]
race-fix

Review of attachment 9049225 [details] [diff] [review]:
-----------------------------------------------------------------

This is okay for me to unblock LSNG landing, but please file a follow-up (or leave this bug open) to actually fix the test issues.
Attachment #9049225 - Flags: review+
Pushed by jvarga@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9dde4b9b46e2
browser/components/preferences/in-content/tests/siteData/browser_siteData2.js fails with LSNG enabled; r=johannh

https://hg.mozilla.org/mozilla-central/rev/9dde4b9b46e2

Status: NEW → RESOLVED
Closed: 5 months ago
status-firefox67: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.