Rearrange some code to prepare for cross-process shared font list

RESOLVED FIXED in Firefox 68

Status

()

enhancement
P3
normal
RESOLVED FIXED
2 months ago
23 days ago

People

(Reporter: jfkthame, Assigned: jfkthame, NeedInfo)

Tracking

(Blocks 1 bug)

unspecified
mozilla68
Points:
---

Firefox Tracking Flags

(Fission Milestone:?, firefox68 fixed)

Details

Attachments

(8 attachments)

47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
(Assignee)

Description

2 months ago

In preparation for the shared-font-list being implemented in bug 1514869, it's helpful to do some shuffling-around of existing code, avoiding some #includes that end up causing conflicts (especially with windows headers) when they get pulled in by generated bindings code, and moving some utility functions to places where they'll be more easily usable by new code.

(Assignee)

Updated

2 months ago
Assignee: nobody → jfkthame
Fission Milestone: --- → ?
(Assignee)

Comment 5

a month ago

This will allow upcoming shared font-list to use the same helpers as the existing code.

Depends on D22922

Attachment #9049889 - Attachment description: Bug 1533428 - patch 1 - Use fully-qualified name for mozilla::ipc::FileDescriptor in AutoMemMap.h, rather than depending on a 'using' declaration. r?jwatt → Bug 1533428 - patch 1 - Use fully-qualified name for mozilla::ipc::FileDescriptor in AutoMemMap.h, rather than depending on a 'using' declaration. r=jwatt
Attachment #9049894 - Attachment description: Bug 1533428 - patch 2 - Move the Orientation enum from gfxFont to nsFontMetrics to enable some #include-elimination, in particular to avoid including gfxTextRun.h in nsFontMetrics.h. r?jwatt → Bug 1533428 - patch 2 - Move the Orientation enum from gfxFont to nsFontMetrics to enable some #include-elimination, in particular to avoid including gfxTextRun.h in nsFontMetrics.h. r=jwatt
Attachment #9049899 - Attachment description: Bug 1533428 - patch 3 - Avoid including gfxTextRun.h in the CanvasRenderingContext2d.h header. r?jwatt → Bug 1533428 - patch 3 - Avoid including gfxTextRun.h in the CanvasRenderingContext2d.h header. r=jwatt
Attachment #9049903 - Attachment description: Bug 1533428 - patch 4 - Include chromium-config.mozbuild in the moz.build for a bunch more directories, so that IPC-related headers are available. r?jwatt → Bug 1533428 - patch 4 - Include chromium-config.mozbuild in the moz.build for a bunch more directories, so that IPC-related headers are available. r=jwatt
Attachment #9049907 - Attachment description: Bug 1533428 - patch 5 - Move the helper functions that measure the 'distance' between values of font properties (weight, stretch, style) to gfxFontUtils.h. r?jwatt → Bug 1533428 - patch 5 - Move the helper functions that measure the 'distance' between values of font properties (weight, stretch, style) to gfxFontUtils.h. r=jwatt
Attachment #9049911 - Attachment description: Bug 1533428 - patch 6 - Consistently use the gfxPlatformFontList::PrefFontList type instead of repeatedly spelling out the array declaration. r?jwatt → Bug 1533428 - patch 6 - Consistently use the gfxPlatformFontList::PrefFontList type instead of repeatedly spelling out the array declaration. r=jwatt
Attachment #9049915 - Attachment description: Bug 1533428 - patch 7 - Create a FontFamily type that wraps either a gfxFontFamily pointer or a mozilla::fontlist::Family pointer (to be used by the shared font list), and use this in various places where we need to pass families around. r?jwatt → Bug 1533428 - patch 7 - Create a FontFamily type that wraps either a gfxFontFamily pointer or a mozilla::fontlist::Family pointer (to be used by the shared font list), and use this in various places where we need to pass families around. r=jwatt
Attachment #9049916 - Attachment description: Bug 1533428 - patch 8 - Move the ReadOtherFamilyNamesForFace helper to gfxFontUtils, for use by shared fontlist code as well as by old gfxFontFamily. r?jwatt → Bug 1533428 - patch 8 - Move the ReadOtherFamilyNamesForFace helper to gfxFontUtils, for use by shared fontlist code as well as by old gfxFontFamily. r=jwatt

There are some r+ patches which didn't land and no activity in this bug for 2 weeks.
:jfkthame, could you have a look please?

Flags: needinfo?(jfkthame)

Comment 10

23 days ago
Pushed by jkew@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2d6b3268f45c
patch 1 - Use fully-qualified name for mozilla::ipc::FileDescriptor in AutoMemMap.h, rather than depending on a 'using' declaration. r=jwatt
https://hg.mozilla.org/integration/autoland/rev/a4e2c4690d8d
patch 2 - Move the Orientation enum from gfxFont to nsFontMetrics to enable some #include-elimination, in particular to avoid including gfxTextRun.h in nsFontMetrics.h. r=jwatt
https://hg.mozilla.org/integration/autoland/rev/075921737c95
patch 3 - Avoid including gfxTextRun.h in the CanvasRenderingContext2d.h header. r=jwatt
https://hg.mozilla.org/integration/autoland/rev/cbf40b5419bd
patch 4 - Include chromium-config.mozbuild in the moz.build for a bunch more directories, so that IPC-related headers are available. r=jwatt
https://hg.mozilla.org/integration/autoland/rev/3de67e6f53f2
patch 5 - Move the helper functions that measure the 'distance' between values of font properties (weight, stretch, style) to gfxFontUtils.h. r=jwatt
https://hg.mozilla.org/integration/autoland/rev/cbf5d7dfe34a
patch 6 - Consistently use the gfxPlatformFontList::PrefFontList type instead of repeatedly spelling out the array declaration. r=jwatt
https://hg.mozilla.org/integration/autoland/rev/04c04203c03f
patch 7 - Create a FontFamily type that wraps either a gfxFontFamily pointer or a mozilla::fontlist::Family pointer (to be used by the shared font list), and use this in various places where we need to pass families around. r=jwatt
https://hg.mozilla.org/integration/autoland/rev/545b89e876f2
patch 8 - Move the ReadOtherFamilyNamesForFace helper to gfxFontUtils, for use by shared fontlist code as well as by old gfxFontFamily. r=jwatt
You need to log in before you can comment on or make changes to this bug.