1533466 - Intermittent TV dom/ipc/tests/browser_JSWindowActor.js | Should throw if includeChrome is false. -

Status: RESOLVED FIXED

(Core :: IPC, defect, P1)

Description

[Treeherder Bug Filer]

#[markdown(off)]
Filed by: aciure [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=232469435&repo=autoland

https://queue.taskcluster.net/v1/task/Dlg3gVHLQdOstm9DnmzWow/runs/0/artifacts/public/logs/live_backing.log

[task 2019-03-07T17:43:19.848Z] 17:43:19 INFO - TEST-PASS | dom/ipc/tests/browser_JSWindowActor.js | JSWindowActorChild should have value. - {} == true -
[task 2019-03-07T17:43:19.850Z] 17:43:19 INFO - Leaving test bound test_getActor_with_allFrames
[task 2019-03-07T17:43:19.853Z] 17:43:19 INFO - Entering test bound test_getActor_without_includeChrome
[task 2019-03-07T17:43:19.854Z] 17:43:19 INFO - Buffered messages finished
[task 2019-03-07T17:43:19.855Z] 17:43:19 INFO - TEST-UNEXPECTED-FAIL | dom/ipc/tests/browser_JSWindowActor.js | Should throw if includeChrome is false. -
[task 2019-03-07T17:43:19.856Z] 17:43:19 INFO - Stack trace:
[task 2019-03-07T17:43:19.857Z] 17:43:19 INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.ok:275
[task 2019-03-07T17:43:19.857Z] 17:43:19 INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.doesThrow:343
[task 2019-03-07T17:43:19.859Z] 17:43:19 INFO - chrome://mochitests/content/browser/dom/ipc/tests/browser_JSWindowActor.js:test_getActor_without_includeChrome:97
[task 2019-03-07T17:43:19.859Z] 17:43:19 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1106
[task 2019-03-07T17:43:19.860Z] 17:43:19 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1134
[task 2019-03-07T17:43:19.861Z] 17:43:19 INFO - chrome://mochikit/content/browser-test.js:nextTest/<:990
[task 2019-03-07T17:43:19.862Z] 17:43:19 INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:803
[task 2019-03-07T17:43:19.865Z] 17:43:19 INFO - Leaving test bound test_getActor_without_includeChrome
[task 2019-03-07T17:43:19.866Z] 17:43:19 INFO - Entering test bound test_getActor_with_includeChrome
[task 2019-03-07T17:43:19.867Z] 17:43:19 INFO - TEST-PASS | dom/ipc/tests/browser_JSWindowActor.js | JSWindowActorParent should have value. -

Comment 1

[Intermittent Failures Robot]

7 failures in 2818 pushes (0.002 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 7

Platform breakdown:

• osx-10-10: 2
• linux64: 2
• windows10-64: 2
• windows7-32: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1533466&startday=2019-03-04&endday=2019-03-10&tree=all

Comment 3

[Natalia Csoregi [:nataliaCs]]

There have been 33 failures within the last 7 days:

• 5 failures on Linux x64 debug/pgo
• 2 failures on Linux x64 shippable opt
• 5 failures on OS X 10.10 debug/opt
• 3 failures on OS X 10.10 shippable opt
• 6 failures on Windows 10 x64 debug/opt/pgo
• 3 failures on Windows 10 x64 Shippable opt
• 6 failures on Windows 7 debug/opt/pgo
• 3 failures on Windows 7 Shippable opt

Recent failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=236578187&repo=mozilla-inbound&lineNumber=11991

[task 2019-03-28T11:23:52.035Z] 11:23:52 INFO - TEST-PASS | dom/ipc/tests/browser_JSWindowActor.js | JSWindowActorChild should have value. - {} == true -
[task 2019-03-28T11:23:52.035Z] 11:23:52 INFO - Leaving test bound test_getActor_with_allFrames
[task 2019-03-28T11:23:52.035Z] 11:23:52 INFO - Entering test bound test_getActor_without_includeChrome
[task 2019-03-28T11:23:52.035Z] 11:23:52 INFO - Buffered messages finished
[task 2019-03-28T11:23:52.044Z] 11:23:52 INFO - TEST-UNEXPECTED-FAIL | dom/ipc/tests/browser_JSWindowActor.js | Should throw if includeChrome is false. -
[task 2019-03-28T11:23:52.049Z] 11:23:52 INFO - Stack trace:
[task 2019-03-28T11:23:52.049Z] 11:23:52 INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.ok:275
[task 2019-03-28T11:23:52.050Z] 11:23:52 INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.doesThrow:343
[task 2019-03-28T11:23:52.052Z] 11:23:52 INFO - chrome://mochitests/content/browser/dom/ipc/tests/browser_JSWindowActor.js:test_getActor_without_includeChrome:384
[task 2019-03-28T11:23:52.053Z] 11:23:52 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1106
[task 2019-03-28T11:23:52.054Z] 11:23:52 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1134
[task 2019-03-28T11:23:52.055Z] 11:23:52 INFO - chrome://mochikit/content/browser-test.js:nextTest/<:990
[task 2019-03-28T11:23:52.061Z] 11:23:52 INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:803
[task 2019-03-28T11:23:52.062Z] 11:23:52 INFO - Leaving test bound test_getActor_without_includeChrome
[task 2019-03-28T11:23:52.063Z] 11:23:52 INFO - Entering test bound test_getActor_with_includeChrome
[task 2019-03-28T11:23:52.070Z] 11:23:52 INFO - TEST-PASS | dom/ipc/tests/browser_JSWindowActor.js | JSWindowActorParent should have value. -

Comment 4

[Intermittent Failures Robot]

17 failures in 960 pushes (0.018 failures/push) were associated with this bug yesterday.

Repository breakdown:

• mozilla-central: 9
• mozilla-inbound: 8

Platform breakdown:

• linux64: 2
• osx-10-10: 2
• windows10-64: 3
• windows7-32: 3
• osx-10-10-shippable: 2
• windows10-64-shippable: 2
• windows7-32-shippable: 2
• linux64-shippable: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1533466&startday=2019-03-28&endday=2019-03-28&tree=all

Comment 5

[Intermittent Failures Robot]

33 failures in 3910 pushes (0.008 failures/push) were associated with this bug in the last 7 days.

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. **

Repository breakdown:

• autoland: 16
• mozilla-central: 9
• mozilla-inbound: 8

Platform breakdown:

• linux64: 5
• osx-10-10: 5
• windows10-64: 6
• windows7-32: 6
• osx-10-10-shippable: 3
• linux64-shippable: 2
• windows10-64-shippable: 3
• windows7-32-shippable: 3

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1533466&startday=2019-03-25&endday=2019-03-31&tree=all

Comment 6

[Jim Mathies [:jimm]]

moving this to ipc for triage.

Comment 7

[Nika Layzell [:nika] (ni? for response)]

This is caused by the tests re-using the same global in some cases when they shouldn't be. I'll take this as it should be a pretty quick fix.

Comment 8

[Nika Layzell [:nika] (ni? for response)]

Attachment: Bug 1533466 - Use a new window for each JSWindowActor test,

Comment 9

[Andreea Pavel [:apavel]]

Nika can we add this t the checkin-needed queue?

Comment 10

[Nika Layzell [:nika] (ni? for response)]

updated & queued for landing with lando

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d29ba08c6cd9
Use a new window for each JSWindowActor test, r=jdai

Comment 12

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/d29ba08c6cd9

Comment 13

[Intermittent Failures Robot]

14 failures in 3031 pushes (0.005 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 8
• mozilla-central: 4
• mozilla-inbound: 2

Platform breakdown:

• linux64: 1
• osx-10-10: 1
• windows7-32: 2
• windows10-64: 2
• osx-10-10-shippable: 1
• linux64-shippable: 1
• windows7-32-shippable: 3
• windows10-64-shippable: 3

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1533466&startday=2019-04-22&endday=2019-04-28&tree=all