Closed Bug 1533473 Opened 5 years ago Closed 5 years ago

Quantumbar autocomplete items are too tall in Touch mode

Categories

(Firefox :: Address Bar, defect, P2)

defect

Tracking

()

RESOLVED FIXED
Firefox 67
Tracking Status
firefox67 --- fixed

People

(Reporter: itiel_yn8, Assigned: dao)

References

Details

Attachments

(3 files)

Attached image Quantum bar on

See attached for Quantum Bar on vs off.

Attached image Quantum bar off
Attachment #9049264 - Attachment description: Quantum bar on.png → Quantum bar on

Is this in tablet mode?

Flags: needinfo?(itiel_yn8)

(In reply to Marco Bonardo [::mak] from comment #2)

Is this in tablet mode?

Forgot to mention that, yes.

Flags: needinfo?(itiel_yn8)
Summary: Autocomplete item height is bigger when Quantum Bar is on → Autocomplete item height is bigger in tablet mode / when Density is set to Touch, if Quantum Bar is on

Dao, what's the expected aspect in tablet mode?

Flags: needinfo?(dao+bmo)
Assignee: nobody → dao+bmo
Status: NEW → ASSIGNED
Flags: needinfo?(dao+bmo)
Priority: -- → P2
Summary: Autocomplete item height is bigger in tablet mode / when Density is set to Touch, if Quantum Bar is on → Quantumbar autocomplete items are too tall in Touch mode
No longer blocks: quantumbar
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d32fb9706939
Reduce quantumbar row height to 40px in touch mode. r=Standard8
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 67

On latest Nightly this now looks much better, but not the same as non-quantum, and the items are now a bit shorter in quantum than in non-quantum.

Dao, is it negligible enough to be accepted for quantum? This is basically now the same in bug 1534731 but for Touch as well.
If the answer is yes then I think bug 1534731 can be closed as RESOLVED WONTFIX...

Flags: needinfo?(dao+bmo)
Flags: needinfo?(dao+bmo)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: