Quantumbar autocomplete items are too tall in Touch mode

RESOLVED FIXED in Firefox 67
(NeedInfo from)

Status

()

defect
P2
normal
RESOLVED FIXED
3 months ago
2 months ago

People

(Reporter: itiel_yn8, Assigned: dao, NeedInfo)

Tracking

(Blocks 2 bugs)

unspecified
Firefox 67
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox67 fixed)

Details

Attachments

(3 attachments)

Reporter

Description

3 months ago
Posted image Quantum bar on

See attached for Quantum Bar on vs off.

Reporter

Comment 1

3 months ago
Posted image Quantum bar off
Reporter

Updated

3 months ago
Attachment #9049264 - Attachment description: Quantum bar on.png → Quantum bar on

Is this in tablet mode?

Flags: needinfo?(itiel_yn8)
Reporter

Comment 3

3 months ago

(In reply to Marco Bonardo [::mak] from comment #2)

Is this in tablet mode?

Forgot to mention that, yes.

Flags: needinfo?(itiel_yn8)
Summary: Autocomplete item height is bigger when Quantum Bar is on → Autocomplete item height is bigger in tablet mode / when Density is set to Touch, if Quantum Bar is on

Dao, what's the expected aspect in tablet mode?

Flags: needinfo?(dao+bmo)
Assignee

Updated

2 months ago
Assignee: nobody → dao+bmo
Status: NEW → ASSIGNED
Flags: needinfo?(dao+bmo)
Priority: -- → P2
Summary: Autocomplete item height is bigger in tablet mode / when Density is set to Touch, if Quantum Bar is on → Quantumbar autocomplete items are too tall in Touch mode
Assignee

Updated

2 months ago
No longer blocks: quantumbar

Comment 6

2 months ago
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d32fb9706939
Reduce quantumbar row height to 40px in touch mode. r=Standard8

Comment 7

2 months ago
bugherder
Status: ASSIGNED → RESOLVED
Last Resolved: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 67
Reporter

Comment 8

2 months ago

On latest Nightly this now looks much better, but not the same as non-quantum, and the items are now a bit shorter in quantum than in non-quantum.

Dao, is it negligible enough to be accepted for quantum? This is basically now the same in bug 1534731 but for Touch as well.
If the answer is yes then I think bug 1534731 can be closed as RESOLVED WONTFIX...

Flags: needinfo?(dao+bmo)
You need to log in before you can comment on or make changes to this bug.