Confirmation hint panel is missing "Saved to Library!"/"Copied to clipboard!" text after landing patch from bug #1528955

VERIFIED FIXED in Firefox 67

Status

()

defect
P1
major
VERIFIED FIXED
5 months ago
2 months ago

People

(Reporter: Virtual, Assigned: rrosario)

Tracking

({nightly-community, regression})

67 Branch
Firefox 67
x86_64
Windows 7
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox-esr60 unaffected, firefox65 unaffected, firefox66 unaffected, firefox67 verified)

Details

Attachments

(2 attachments, 2 obsolete attachments)

STR:

  1. Bookmark some website page
    and see that confirmation hint panel is missing missing "Saved to Library!" text

and looks like mozregression-gui is kinda broken, as it can't locate regression

Summary: Confirmation hint panel is missing "Saved to Library!" text → Bookmark confirmation hint panel is missing "Saved to Library!" text
Blocks: 1528955
Has Regression Range: --- → yes

:r1cky
Your patch seems to cause the regression. Can you please look into this?

Flags: needinfo?(rrosario)

On Ubuntu the confirmation does display "Saved to Library".

Priority: -- → P1

@ Alice0775 White - Thank you very much for finding specific regression range!

Summary: Bookmark confirmation hint panel is missing "Saved to Library!" text → Bookmark confirmation hint panel is missing "Saved to Library!" text after landing patch from bug #1528955

(In reply to Alice0775 White from comment #6)

:r1cky
Your patch seems to cause the regression. Can you please look into this?

Yes, will do.

Assignee: nobody → rrosario
Flags: needinfo?(rrosario)
Pushed by rrosario@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3a8323264398
Bookmark confirmation hint panel is missing "Saved to Library!" text after landing patch from bug #1528955 r=dao
Status: NEW → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 67
See Also: → 1534954
Blocks: 1501751
Duplicate of this bug: 1534954

I'm confirming that bug is fixed, starting in Mozilla Firefox Nightly 67.0a1 (2019-03-13), so I'm marking this bug as VERIFIED.
Thank you very much! \o/

Status: RESOLVED → VERIFIED
See Also: 1534954
Summary: Bookmark confirmation hint panel is missing "Saved to Library!" text after landing patch from bug #1528955 → Confirmation hint panel is missing "Saved to Library!"/"Copied to clipboard!" text after landing patch from bug #1528955
You need to log in before you can comment on or make changes to this bug.