Remove defer usage in devtools/client/shared/widgets/Graphs.js

RESOLVED FIXED in Firefox 67

Status

enhancement
P3
normal
RESOLVED FIXED
3 months ago
2 months ago

People

(Reporter: nchevobbe, Assigned: fanny, Mentored)

Tracking

(Blocks 1 bug, {good-first-bug})

Trunk
Firefox 67
Dependency tree / graph

Firefox Tracking Flags

(firefox67 fixed)

Details

Attachments

(1 attachment)

Reporter

Description

3 months ago

We should use new Promise instead.

Reporter

Updated

3 months ago
Mentor: nchevobbe
Keywords: good-first-bug

Hi, nicolas, do you can assign this task for me? What I need to do is based on this here, right?

Reporter

Comment 2

3 months ago

Hello Fanny, the bug is yours :)
What needs to be done is remove the import of the defer module, and use the standard new Promise((res, rej) => {}) notation instead.
You can check the resolved blocking bugs of Bug 1283869 to get an idea how some of them were fixed, and how you could do it.

Assignee: nobody → fannyvieira082
Status: NEW → ASSIGNED

Thanks!

Comment 5

2 months ago
bugherder
Status: ASSIGNED → RESOLVED
Last Resolved: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 67
You need to log in before you can comment on or make changes to this bug.