1533657 - Remove defer usage in devtools/client/shared/widgets/Graphs.js

Status: RESOLVED FIXED

(DevTools :: Shared Components, enhancement, P3)

Description

[Nicolas Chevobbe [:nchevobbe]]

We should use new Promise instead.

Comment 1

[Fanny Batista Vieira [:fanny] [:fanny]]

Hi, nicolas, do you can assign this task for me? What I need to do is based on this here, right?

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

Hello Fanny, the bug is yours :)
What needs to be done is remove the import of the defer module, and use the standard new Promise((res, rej) => {}) notation instead.
You can check the resolved blocking bugs of Bug 1283869 to get an idea how some of them were fixed, and how you could do it.

Comment 3

[Fanny Batista Vieira [:fanny] [:fanny]]

Thanks!

Comment 4

[Fanny Batista Vieira [:fanny] [:fanny]]

Attachment: Bug 1533657 - Remove defer usage in devtools/client/shared/widgets/Graphs.js. r=nchevobbe!

Remove defer and update to promise

Comment 5

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/7f25b37567b2

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/integration/autoland/rev/7f25b37567b210d3043dee744d7885aa836ecca7