Closed Bug 1533691 Opened 2 years ago Closed 2 years ago

Uncomment the selection setting code in UrlbarInput

Categories

(Firefox :: Address Bar, enhancement, P2)

Product:
Firefox
Component:
Address Bar
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 67
Tracking Flags:
Tracking Status
firefox67 --- fixed

People

(Reporter: mak, Assigned: jawad)

References

Details

(Whiteboard: [fxsearch])

Attachments

(1 file)

Bug 1533691 - Uncommented the code and removed TODO comment. r=mak
47 bytes, text/x-phabricator-request
Details | Review

This code has been commented out for some unclear reasons and the todo comment is wrong.
https://searchfox.org/mozilla-central/rev/fbb251448feb7276f9b1d0a88f9c0cb1cd144ce4/browser/components/urlbar/UrlbarInput.jsm#917

That is necessary for spoof protection, so that the domain stays visible.

Hi, should i do it? Please assign it to me :)

Feel free to provide a patch removing the TODO comment and uncommenting the code, we assign on the first patch.

(In reply to Marco Bonardo [::mak] from comment #2)

Feel free to provide a patch removing the TODO comment and uncommenting the code, we assign on the first patch.

Thank you :)

Assignee: nobody → ijawadak
Status: NEW → ASSIGNED
Pushed by mak77@bonardo.net:
https://hg.mozilla.org/integration/autoland/rev/57f4edb121f3
Uncommented the code and removed TODO comment. r=mak

https://hg.mozilla.org/mozilla-central/rev/57f4edb121f3

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox67: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 67
Depends on: 1534552
You need to log in before you can comment on or make changes to this bug.