1533691 - Uncomment the selection setting code in UrlbarInput

Status: RESOLVED FIXED

(Firefox :: Address Bar, enhancement, P2)

Description

[Marco Bonardo [:mak]]

This code has been commented out for some unclear reasons and the todo comment is wrong.
https://searchfox.org/mozilla-central/rev/fbb251448feb7276f9b1d0a88f9c0cb1cd144ce4/browser/components/urlbar/UrlbarInput.jsm#917

That is necessary for spoof protection, so that the domain stays visible.

Comment 1

[Jawad Ahmed [:jawad]]

Hi, should i do it? Please assign it to me :)

Comment 2

[Marco Bonardo [:mak]]

Feel free to provide a patch removing the TODO comment and uncommenting the code, we assign on the first patch.

Comment 3

[Jawad Ahmed [:jawad]]

Attachment: Bug 1533691 - Uncommented the code and removed TODO comment. r=mak

Comment 4

[Jawad Ahmed [:jawad]]

(In reply to Marco Bonardo [::mak] from comment #2)

Feel free to provide a patch removing the TODO comment and uncommenting the code, we assign on the first patch.

Thank you :)

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/57f4edb121f3
Uncommented the code and removed TODO comment. r=mak

Comment 6

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/57f4edb121f3