1533716 - Make out-of-process iframes able to request focus

Status: RESOLVED FIXED

(Core :: DOM: Content Processes, defect)

Description

[Henri Sivonen (:hsivonen)]

When bug 1524977 landed, it was possible to move focus into an out-of-process iframe by tabbing such that it was possible to see the out-of-process iframe draw its top-level focus ring in response to tabbing into it.

In the past few days this broke somehow. The out-of-process iframe runs the focusing code to set its focused element in response to RecvNavigateByKey() and calls TabChild::SendRequestFocus() afterwards. Then focus stays in the iframe parent Web content without whatever was focused there losing focus and without the out-of-process iframe drawing its top-level focus ring.

Comment 1

[Henri Sivonen (:hsivonen)]

nika, rhunt, can you think of what might have broken this?

Comment 2

[Ryan Hunt [:rhunt] (on leave until early May)]

I haven't landed anything fission related in a while, so nothing stands out on my end.

Comment 3

[Henri Sivonen (:hsivonen)]

Sadly, due to last week's bindgen issues, it looks like the toolchain from the end of last week isn't compatible with the code from the start of last week, so it's not really practical to bisect this.

Comment 4

[Henri Sivonen (:hsivonen)]

Current hypothesis of cause:
TabParent::mFrameElement for out-of-process iframes gets set to the XUL frame instead of the HTML iframe.

Comment 5

[Henri Sivonen (:hsivonen)]

(In reply to Henri Sivonen (:hsivonen) from comment #4)

Current hypothesis of cause:
TabParent::mFrameElement for out-of-process iframes gets set to the XUL frame instead of the HTML iframe.

And of course it is, because the iframe element isn't in the process that the TabParent is in. Looks like RequestFocus needs to bounce back down via BrowserBridge.

Comment 6

[Henri Sivonen (:hsivonen)]

I have a patch for this.

Comment 7

[Henri Sivonen (:hsivonen)]

Attachment: Bug 1533716 - Make out-of-process iframes able to request focus.

Depends on D22972

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1a69c88b8863
Make out-of-process iframes able to request focus. r=masayuki,NeilDeakin

Comment 9

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/1a69c88b8863