Closed Bug 1533725 Opened 1 year ago Closed 1 year ago

Enable column breakpoints by default

Categories

(DevTools :: Debugger, enhancement)

enhancement
Not set

Tracking

(firefox67 fixed)

RESOLVED FIXED
Firefox 67
Tracking Status
firefox67 --- fixed

People

(Reporter: jlast, Assigned: jlast)

References

Details

Attachments

(1 file)

No description provided.
Pushed by jlaster@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/76a4586acec2
Enable column breakpoints by default. r=loganfsmyth

Backed out for debugger failures

backout: https://hg.mozilla.org/integration/autoland/rev/ba5efb7afd8f158d52e3b0c69a445c03ccfb4a08

push: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=76a4586acec25abf778964c339bfde630bd2cce4&searchStr=linux%2Cx64%2Copt%2Cnode%2Ctests%2Csource-test-node-debugger-tests%2Cnode%28debugger%29&selectedJob=232775153

failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=232775153&repo=autoland

[task 2019-03-08T21:56:50.218Z] ● Breakpoint › paused at a different
[task 2019-03-08T21:56:50.218Z]
[task 2019-03-08T21:56:50.218Z] expect(value).toMatchSnapshot()
[task 2019-03-08T21:56:50.219Z]
[task 2019-03-08T21:56:50.219Z] Received value does not match stored snapshot "Breakpoint paused at a different 1".
[task 2019-03-08T21:56:50.219Z]
[task 2019-03-08T21:56:50.219Z] - Snapshot
[task 2019-03-08T21:56:50.220Z] + Received
[task 2019-03-08T21:56:50.220Z]
[task 2019-03-08T21:56:50.220Z] @@ -27,11 +27,11 @@
[task 2019-03-08T21:56:50.220Z] className="breakpoint-line-close"
[task 2019-03-08T21:56:50.221Z] >
[task 2019-03-08T21:56:50.221Z] <div
[task 2019-03-08T21:56:50.221Z] className="breakpoint-line devtools-monospace"
[task 2019-03-08T21:56:50.221Z] >
[task 2019-03-08T21:56:50.222Z] - 53
[task 2019-03-08T21:56:50.222Z] + 53:73
[task 2019-03-08T21:56:50.222Z] </div>
[task 2019-03-08T21:56:50.222Z] <CloseButton
[task 2019-03-08T21:56:50.222Z] handleClick={[Function]}
[task 2019-03-08T21:56:50.222Z] tooltip="Remove breakpoint"
[task 2019-03-08T21:56:50.223Z] />
[task 2019-03-08T21:56:50.223Z]
[task 2019-03-08T21:56:50.223Z] 45 | frame: { selectedLocation: { ...generatedLocation, line: 14 } }
[task 2019-03-08T21:56:50.224Z] 46 | });
[task 2019-03-08T21:56:50.224Z] > 47 | expect(component).toMatchSnapshot();
[task 2019-03-08T21:56:50.224Z] | ^
[task 2019-03-08T21:56:50.224Z] 48 | });
[task 2019-03-08T21:56:50.225Z] 49 | });
[task 2019-03-08T21:56:50.225Z] 50 |
[task 2019-03-08T21:56:50.225Z]
[task 2019-03-08T21:56:50.226Z] at Object.it (src/components/SecondaryPanes/Breakpoints/tests/Breakpoint.spec.js:47:23)
[task 2019-03-08T21:56:50.226Z]
[task 2019-03-08T21:56:50.226Z]
[task 2019-03-08T21:56:50.228Z] Snapshot Summary
[task 2019-03-08T21:56:50.228Z] › 5 snapshots failed from 1 test suite. Inspect your code changes or run yarn test -u to update them.
[task 2019-03-08T21:56:50.228Z]
[task 2019-03-08T21:56:50.229Z] Test Suites: 1 failed, 197 passed, 198 total
[task 2019-03-08T21:56:50.229Z] Tests: 5 failed, 10 skipped, 1664 passed, 1679 total
[task 2019-03-08T21:56:50.229Z] Snapshots: 5 failed, 428 passed, 433 total
[task 2019-03-08T21:56:50.229Z] Time: 200.975s
[task 2019-03-08T21:56:50.229Z] Ran all test suites in 5 projects.
[task 2019-03-08T21:56:50.278Z] error Command failed with exit code 1.
[task 2019-03-08T21:56:50.278Z] info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
[taskcluster 2019-03-08 21:56:51.314Z] === Task Finished ===
[taskcluster 2019-03-08 21:56:51.314Z] Unsuccessful task run with exit code: 1 completed in 590.768 seconds

Flags: needinfo?(jlaster)
Pushed by jlaster@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3c4b55694127
Enable column breakpoints by default. r=loganfsmyth
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 67
Flags: needinfo?(jlaster)
You need to log in before you can comment on or make changes to this bug.