Closed Bug 1533770 Opened 1 year ago Closed 1 year ago

Query intersection messes up presets with multiple queries defined

Categories

(Firefox Build System :: Try, enhancement)

enhancement
Not set
normal

Tracking

(firefox67 fixed)

RESOLVED FIXED
mozilla67
Tracking Status
firefox67 --- fixed

People

(Reporter: ahal, Assigned: ahal)

References

Details

Attachments

(1 file)

In bug 1531360 I implemented the ability to intersect queries by adding a --and argument that changes the behaviour of |mach try fuzzy| to take the intersection of multiple queries instead of the union. But I missed something obvious:

The intersection is all or nothing, which means that if you run a preset like this:

./mach try fuzzy --preset foo -xq "bar"

Then it will take the intersection of all queries defined in the 'foo' preset as well. This is definitely not what the user is intending here.

Pushed by ahalberstadt@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/83169352c088
[fuzzy] Fix query intersection when running presets with multiple queries, r=jgraham
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.