Query intersection messes up presets with multiple queries defined

RESOLVED FIXED in Firefox 67

Status

enhancement
RESOLVED FIXED
3 months ago
2 months ago

People

(Reporter: ahal, Assigned: ahal)

Tracking

unspecified
mozilla67
Dependency tree / graph

Firefox Tracking Flags

(firefox67 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

3 months ago

In bug 1531360 I implemented the ability to intersect queries by adding a --and argument that changes the behaviour of |mach try fuzzy| to take the intersection of multiple queries instead of the union. But I missed something obvious:

The intersection is all or nothing, which means that if you run a preset like this:

./mach try fuzzy --preset foo -xq "bar"

Then it will take the intersection of all queries defined in the 'foo' preset as well. This is definitely not what the user is intending here.

Comment 2

2 months ago
Pushed by ahalberstadt@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/83169352c088
[fuzzy] Fix query intersection when running presets with multiple queries, r=jgraham

Comment 3

2 months ago
bugherder
Status: ASSIGNED → RESOLVED
Last Resolved: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.