`this.uriFlags` is undefined in AboutCompat.jsm
Categories
(Web Compatibility :: Interventions, defect)
Tracking
(Not tracked)
People
(Reporter: MattN, Unassigned)
References
Details
if (this.uriFlags & Ci.nsIAboutModule.URI_SAFE_FOR_UNTRUSTED_CONTENT) {
channel.owner = null;
}
channel.owner is never set to null since this.uriFlags is undefined. I think this was just copied from toolkit/components/normandy/content/AboutPages.jsm and not updated properly.
|
||
Comment 1•5 years ago
|
||
Ah, yes, this.uriFlags doesn't exist in the final module (there were several review rounds, and this case got lost in the shuffle).
MattN: do you feel it would be best to drop this clause entirely, or safer to re-add a this.uriFlags member, just in case we ever want about:compat to use this flag as well?
|
Reporter | |
Comment 2•5 years ago
|
||
I think drop the if (assuming that channel.owner = null; is what you really want)
|
||
Comment 3•5 years ago
|
||
(In reply to Matthew N. [:MattN] (PM me if requests are blocking you) from comment #2)
I think drop the
if(assuming thatchannel.owner = null;is what you really want)
It's not. The condition is supposed to evaluate to false.
|
|
Reporter | |
Comment 4•5 years ago
|
||
Oh, yeah, true, I've been looking at too many about: page registrations in the last hour that thought this was one that had URI_SAFE_FOR_UNTRUSTED_CONTENT.
|
|
||
Comment 5•5 years ago
|
||
Then I suppose we might as well just drop that if-statement entirely, if it's going to cause more confusion than it's worth?
|
|
Reporter | |
Comment 6•5 years ago
|
||
(In reply to Thomas Wisniewski [:twisniewski] from comment #5)
Then I suppose we might as well just drop that if-statement entirely, if it's going to cause more confusion than it's worth?
Correct, it's just dead code that should be deleted.
|
|
||
Comment 7•5 years ago
|
||
(In reply to Matthew N. [:MattN] (PM me if requests are blocking you) from comment #6)
(In reply to Thomas Wisniewski [:twisniewski] from comment #5)
Then I suppose we might as well just drop that if-statement entirely, if it's going to cause more confusion than it's worth?
Correct, it's just dead code that should be deleted.
Note I mildly suggested this in my last review :)
|
|
||
Comment 8•5 years ago
|
||
This was just fixed as part of bug 1539916.
Description
•