Closed Bug 1533863 Opened 9 months ago Closed 3 months ago

Replace text with icons in the "about:config" buttons

Categories

(Toolkit :: Preferences, task, P3)

task

Tracking

()

RESOLVED FIXED
mozilla70
Tracking Status
firefox70 --- fixed

People

(Reporter: Paolo, Assigned: mstriemer)

References

Details

Attachments

(1 file)

This is the main part of the UX refresh described in bug 1533856, and requires the icons from bug 1533862.

We may want to implement bug 1504254 before this change lands.

The text of the buttons should become the tooltip. This means the localization strings will change so they set the "title" attribute instead of the text content.

Blocks: 1524855

In bug 1549080 I proposed to have different colors, like red for the remove/delete button.

Type: enhancement → task
Assignee: nobody → mstriemer
Attachment #9088459 - Attachment description: Bug 1533863 - Use icons instead of text for buttons in about:config r?paolo → Bug 1533863 - Use icons instead of text for buttons in about:config r?jaws

Thank you Mark for working on this! Would you also be interested in bug 1504254?

According to Markus, bug 1504254 was required as a consequence of making the buttons narrower. I don't think we should block this bug on getting the other one done, considering it's only halfway through, but it would be good to get that one landed next.

Flags: needinfo?(mstriemer)
Pushed by mstriemer@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/144a7271e9c3
Use icons instead of text for buttons in about:config r=fluent-reviewers,jaws,flod

Yup, I'm planning on going through all the bugs on the meta. I can take a look at that one now.

Flags: needinfo?(mstriemer)
Status: NEW → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
Regressions: 1577768
Depends on: 1578069
Flags: qe-verify+

Hello,

I wanted to verify this bug but I have a question, what does the uplifted patch actually repair? Does it implement buttons in the about:config or does it make it so that "The text of the buttons should become the tooltip. This means the localization strings will change so they set the "title" attribute instead of the text content." ?

Flags: needinfo?(mstriemer)

I don't think this was uplifted to beta. Not sure why the beta commit is linked.

The buttons should now use icons instead of text and the text should be in the title text. It should roughly like https://bug1533856.bmoattachments.org/attachment.cgi?id=9049607.

Flags: needinfo?(mstriemer)
You need to log in before you can comment on or make changes to this bug.