1533943 - [Fission] Make WebNavigation ready for Fission

Status: RESOLVED FIXED

(Toolkit :: General, enhancement, P3)

Description

[:Felipe Gomes (needinfo for replies!)]

WebNavigation is responsible for some part of the loadURI functions and GoBack/GoForward session history navigation. Some of its responsibilities might end up going to the backend, but what is not should be made to work with Fission.

It looks like most of what is in WebNavigationChild.jsm is related to the top-level only, so it might just work outside of the box (wishful thinking?). Anyways, it would still need the parent-side actor work to communicate with it.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

I think we're going to have to move this out to M3.

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Hey Neil, do you think you can take this one?

Comment 3

[Neil Deakin]

The basic implementation looks simple enough, but it has a dependency on WebProgress which may need to be converted over as well.

Comment 4

[Neil Deakin]

Attachment: Bug 1533943, modify WebNavigation to inherit from JSWindowActor

Comment 5

[Neil Deakin]

This patch does the job but there are too many test failures caused by a null browsingContext.currentWindowGlobal. Whether this is bug 1523638 or not I'm not sure, but it isn't feasible to proceed with this patch any further.

Comment 6

[Neha Kochar [:neha]]

Since this depends on bug 1523638 which won't get fixed in M3, I'm moving this out to M4.

Comment 7

[Neil Deakin]

Attachment: Bug 1533943, modify WebNavigation to inherit from JSWindowActor, r=mconley

Comment 8

[Neil Deakin]

Found some android specific failures that I am looking into.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6e3c105cfcde
modify WebNavigation to inherit from JSWindowActor, r=mconley

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/15e1d046f290
Fixed eslint failure at browser/web-navigation.js on a CLOSED TREE.

Comment 11

[Daniel Varga [:dvarga]]

Backed out changeset 6e3c105cfcde (Bug 1533943) for causing mochitest failures at mobile/android/components/extensions/test/mochitest/test_ext_webNavigation_onCommitted.html on a CLOSED TREE

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&selectedJob=276138828&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=6e3c105cfcde3a6821120a83674f77692f5c7bf2

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=276126005&repo=autoland&lineNumber=5574
ESlint failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception&revision=6e3c105cfcde3a6821120a83674f77692f5c7bf2&selectedJob=276115451

Backout link: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=646f38ad2746a55ee42a1d1002f922a69c5b91c5

[task 2019-11-14T03:03:55.789Z] 03:03:55     INFO -  2243 INFO TEST-START | mobile/android/components/extensions/test/mochitest/test_ext_tabs_sendMessage.html
[task 2019-11-14T03:03:55.792Z] 03:03:55     INFO -  2244 INFO TEST-OK | mobile/android/components/extensions/test/mochitest/test_ext_tabs_sendMessage.html | took 498ms
[task 2019-11-14T03:03:55.792Z] 03:03:55     INFO -  2245 INFO TEST-START | mobile/android/components/extensions/test/mochitest/test_ext_webNavigation_onCommitted.html
[task 2019-11-14T03:09:05.856Z] 03:09:05     INFO -  Buffered messages logged at 03:03:47
[task 2019-11-14T03:09:05.857Z] 03:09:05     INFO -  2246 INFO add_task | Entering test
[task 2019-11-14T03:09:05.857Z] 03:09:05     INFO -  2247 INFO Extension loaded
[task 2019-11-14T03:09:05.857Z] 03:09:05     INFO -  Buffered messages finished
[task 2019-11-14T03:09:05.857Z] 03:09:05  WARNING -  2248 INFO TEST-UNEXPECTED-FAIL | mobile/android/components/extensions/test/mochitest/test_ext_webNavigation_onCommitted.html | Test timed out.
[task 2019-11-14T03:09:05.857Z] 03:09:05     INFO -      SimpleTest.ok@SimpleTest/SimpleTest.js:277:18
[task 2019-11-14T03:09:05.858Z] 03:09:05     INFO -      reportError@SimpleTest/TestRunner.js:121:22
[task 2019-11-14T03:09:05.858Z] 03:09:05     INFO -      TestRunner._checkForHangs@SimpleTest/TestRunner.js:142:18
[task 2019-11-14T03:09:16.434Z] 03:09:16  WARNING -  2249 INFO TEST-UNEXPECTED-FAIL | mobile/android/components/extensions/test/mochitest/test_ext_webNavigation_onCommitted.html | Extension left running at test shutdown
[task 2019-11-14T03:09:16.434Z] 03:09:16     INFO -      SimpleTest.ok@SimpleTest/SimpleTest.js:277:18
[task 2019-11-14T03:09:16.435Z] 03:09:16     INFO -      ExtensionTestUtils.loadExtension/<@SimpleTest/ExtensionTestUtils.js:109:18
[task 2019-11-14T03:09:16.435Z] 03:09:16     INFO -      executeCleanupFunction@SimpleTest/SimpleTest.js:1238:19
[task 2019-11-14T03:09:16.436Z] 03:09:16     INFO -      SimpleTest.finish@SimpleTest/SimpleTest.js:1251:5
[task 2019-11-14T03:09:16.436Z] 03:09:16     INFO -      killTest@SimpleTest/TestRunner.js:130:22
[task 2019-11-14T03:09:16.437Z] 03:09:16     INFO -  2250 INFO TEST-OK | mobile/android/components/extensions/test/mochitest/test_ext_webNavigation_onCommitted.html | took 318644ms
[task 2019-11-14T03:09:16.438Z] 03:09:16     INFO -  2251 ERROR /tests/mobile/android/components/extensions/test/mochitest/test_ext_webNavigation_onCommitted.html logged result after SimpleTest.finish(): Extension left running at test shutdown
[task 2019-11-14T03:09:16.438Z] 03:09:16     INFO -  2252 INFO TEST-START | Shutdown
[task 2019-11-14T03:09:16.438Z] 03:09:16     INFO -  2253 INFO Passed:  135
[task 2019-11-14T03:09:16.439Z] 03:09:16  WARNING -  2254 INFO Failed:  3
[task 2019-11-14T03:09:16.439Z] 03:09:16  WARNING -  One or more unittests failed.
[task 2019-11-14T03:09:16.439Z] 03:09:16     INFO -  2255 INFO Todo:    2
[task 2019-11-14T03:09:16.440Z] 03:09:16     INFO -  2256 INFO Mode:    e10s
[task 2019-11-14T03:09:16.440Z] 03:09:16     INFO -  2257 INFO Slowest: 318643ms - /tests/mobile/android/components/extensions/test/mochitest/test_ext_webNavigation_onCommitted.html
[task 2019-11-14T03:09:16.440Z] 03:09:16     INFO -  2258 INFO SimpleTest FINISHED
[task 2019-11-14T03:09:18.701Z] 03:09:18     INFO -  wait for org.mozilla.geckoview.test complete; top activity=com.android.launcher3
[task 2019-11-14T03:09:18.817Z] 03:09:18     INFO -  remoteautomation.py | Application ran for: 0:05:46.849990
[task 2019-11-14T03:09:19.580Z] 03:09:19     INFO -  Stopping web server
[task 2019-11-14T03:09:19.589Z] 03:09:19     INFO -  Stopping web socket server
[task 2019-11-14T03:09:19.610Z] 03:09:19     INFO -  Stopping ssltunnel
[task 2019-11-14T03:09:19.631Z] 03:09:19     INFO -  leakcheck | refcount logging is off, so leaks can't be detected!
[task 2019-11-14T03:09:19.631Z] 03:09:19     INFO -  runtests.py | Running tests: end.
[task 2019-11-14T03:09:21.025Z] 03:09:21     INFO -  Buffered messages finished
[task 2019-11-14T03:09:21.025Z] 03:09:21     INFO -  Running manifest: modules/libjar/test/mochitest/mochitest.ini
[task 2019-11-14T03:09:21.713Z] 03:09:21     INFO -  runtests.py | Failed to copy /builds/worker/workspace/build/tests/mochitest/hyphenation to profile
[task 2019-11-14T03:09:22.477Z] 03:09:22     INFO -  pk12util: PKCS12 IMPORT SUCCESSFUL

Comment 12

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/34daa01d30f7
Backed out changeset 15e1d046f290 for causing conflict when backing out Bug 1533943

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1f6cd5814db9
modify WebNavigation to inherit from JSWindowActor, r=mconley
https://hg.mozilla.org/integration/autoland/rev/15149f31dbf2
Fixed eslint failure at browser/web-navigation.js on a CLOSED TREE.

Comment 14

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/1f6cd5814db9
https://hg.mozilla.org/mozilla-central/rev/15149f31dbf2

Comment 15

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Hello enndeakin. Are there any STR that QA can use to verify this? Thank's!

Comment 16

[Mark Banner (:standard8)]

I'm guessing the QA question is out of date by now. If it isn't please try contacting Neil direct.