Closed Bug 1533967 Opened 3 years ago Closed 3 years ago

Convert item toolbar buttons from type="menu-button" to type="menu"

Categories

(Calendar :: Dialogs, enhancement)

enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: darktrojan, Assigned: darktrojan)

Details

Attachments

(1 file)

In my opinion, the privacy, priority, status, and show-time-as buttons don't need a button action as well as a drop-down. I have a patch to change that, which would help fix bug 1533085.

Also the attachment button, which has one item in the dropdown that does the same as the button. We could do more with that, but for now it just seems silly.

Attachment #9049709 - Flags: review?(philipp)
Comment on attachment 9049709 [details] [diff] [review]
1533967-calendar-menu-button-1.diff

Review of attachment 9049709 [details] [diff] [review]:
-----------------------------------------------------------------

The code looks ok to me. For measure, let's see what Alex has to say about this change. It looks like you wouldn't be able to click to cycle through but would then use the dropdown instead?
Attachment #9049709 - Flags: ui-review?(alessandro)
Attachment #9049709 - Flags: review?(philipp)
Attachment #9049709 - Flags: review+
Comment on attachment 9049709 [details] [diff] [review]
1533967-calendar-menu-button-1.diff

Review of attachment 9049709 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good to me from a UX point of view.
We should follow this approach and avoid having a single button to cycle through options as it's counter intuitive for new users and the button doesn't visually update itself to represent the currently selected status.
Also, it removes the possibility of accidentally cycling through the options if the user clicks the button instead of the dropdown icon if he wants to check the currently selected option.

Maybe we should consider also updating the icons in the buttons to visually represent the currently selected status.
Eg:
* Public Event: open lock
* Private Event: close lock
* etc...

I can open a dedicated Bug for this and start mocking some icons if you guys agree.
Attachment #9049709 - Flags: ui-review?(alessandro) → ui-review+

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/10223e076a03
Convert calendar item toolbar buttons from type="menu-button" to type="menu". r=philipp, ui-r=aleca

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 6.9
You need to log in before you can comment on or make changes to this bug.