1534012 - Consider to add a separate queue for window.postMessage and process it with lower priority during page load

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement, P3)

Description

[Olli Pettay [:smaug][[e-mail]]]

Facebook seems to use postMessage rather early during pageload, and it has some heavy event listener for the message event.

https://perfht.ml/2NQVDG8

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Perhaps the postMessage queue which bug 1512388 needs can be used here.

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Just for testing, to see how much this might affect to page loads
Raptor with a test patch: https://treeherder.mozilla.org/#/jobs?repo=try&revision=21d4ec2101750dfca50005a6806ac5a64b60fd03
Base: https://treeherder.mozilla.org/#/jobs?repo=try&revision=e182aae79a79c5cd3c00d7e057e8925839843b8a

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Looks like this could affect positively to google-mail and yahoo-news. So worth to look at some more.

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Another raptor run to get new numbers with some of the recent patches.

Base: https://treeherder.mozilla.org/#/jobs?repo=try&revision=5768c81a3a4fb01c2c3c69b27fc98c46f59cef8d
patch: https://treeherder.mozilla.org/#/jobs?repo=try&revision=b693e3ba21d4c52d13cb1539b641e00b319b4628

Comment 5

[Sean Feng [:sefeng]]

Attachment: Bug 1534012 - Use a low priority ThrottledEventQueue for postMessages during page load r=smaug

Comment 6

[Sean Feng [:sefeng]]

Try push with flag turned on: https://treeherder.mozilla.org/#/jobs?repo=try&revision=d5d9f8beaee7b39a0c18b9e5136cdb2fb3628010

Comment 7

[Sean Feng [:sefeng]]

WPT bug that needs to be fixed first: https://github.com/web-platform-tests/wpt/issues/16540

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7fa8e33635fc
Use a low priority ThrottledEventQueue for postMessages during page load r=smaug

Comment 9

[Cristian Brindusan [:cbrindusan]]

Backed out changeset 7fa8e33635fc (Bug 1534012) for wpt failures at promise-rejection-events.html.

Backout: https://hg.mozilla.org/integration/autoland/rev/b35cf8000e7a708377696f3859ae6bfa0fa8f554

Push that started the failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&revision=7fa8e33635fcd787ff275d92fd4e9c8df6127d78&selectedJob=245624422

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=245624422&repo=autoland&lineNumber=17735

Comment 10

[Sean Feng [:sefeng]]

Attachment: Bug 1534012 - Update postMessage usage in WPT for promise rejection

PostMessage Event uses "PostMessage task source" which is different
than "DOM manipulation task queue"; Update the code to use detail
object instead.

Depends on D27386

Comment 11

[Sean Feng [:sefeng]]

Expected performance improvements
https://treeherder.mozilla.org/perf.html#/compare?originalProject=try&originalRevision=6f82d7586c7a6a59b4bfc955e5866a30edcc7597&newProject=try&newRevision=af42c89af00b59f61c7fe4bb1f4904d8386bd6fa&framework=10&showOnlyImportant=1

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ef5bf4372b76
Use a low priority ThrottledEventQueue for postMessages during page load r=smaug
https://hg.mozilla.org/integration/autoland/rev/55c360c47f31
Update postMessage usage in WPT for promise rejection r=smaug

Comment 13

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/16925 for changes under testing/web-platform/tests

Comment 14

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

Comment 15

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/ef5bf4372b76
https://hg.mozilla.org/mozilla-central/rev/55c360c47f31

Comment 16

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR merged

Comment 17

[Florin Strugariu [:Bebe]]

== Change summary for alert #21015 (as of Tue, 21 May 2019 07:34:34 GMT) ==

Improvements:

26% raptor-tp6-yahoo-news-firefox loadtime windows10-64-shippable-qr opt 481.21 -> 356.17
26% raptor-tp6-yahoo-news-firefox loadtime windows10-64-shippable opt 481.83 -> 357.71
24% raptor-tp6-yahoo-news-firefox loadtime linux64-shippable-qr opt 510.21 -> 386.79
23% raptor-tp6-yahoo-news-firefox loadtime windows7-32-shippable opt 468.71 -> 362.00
21% raptor-tp6-yahoo-news-firefox loadtime linux64-shippable opt 465.96 -> 365.83
7% raptor-tp6-yahoo-news-firefox windows10-64-shippable opt 290.02 -> 268.48
7% raptor-tp6-yahoo-news-firefox windows10-64-shippable-qr opt 289.48 -> 268.46
5% raptor-tp6-yahoo-news-firefox windows7-32-shippable opt 286.52 -> 270.82
5% raptor-tp6-yahoo-news-firefox linux64-shippable opt 294.51 -> 279.56
5% raptor-tp6-yahoo-news-firefox linux64-shippable-qr opt 314.07 -> 298.39

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=21015

Comment 18

[Sean Feng [:sefeng]]

Attachment: firefox_vs_chrome_yahoo_news.png

Updated a screenshot to show the performance changes between Firefox and Chrome for Yahoo News.