1534024 - Unhandled rejections in tc-github tests

Status: RESOLVED FIXED

(Taskcluster :: Services, defect)

Description

[Dustin J. Mitchell [:dustin] (he/him)]

https://tools.taskcluster.net/groups/faxz7YlETLCQozOqvFkI7Q/tasks/O4eGKY4HQRSP6XahOOyirw/runs/0/logs/public%2Flogs%2Flive_backing.log

      ✓ valid tag push (but not collaborator) creates a taskGroup
      ✓ invalid YAML results in a comment
(node:112) UnhandledPromiseRejectionWarning: #<Object>
(node:112) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 8)
(node:112) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
      ✓ error creating task is reported correctly
(node:112) PromiseRejectionHandledWarning: Promise rejection was handled asynchronously (rejection id: 8)
      ✓ not an org member or collaborator is reported correctly for pull requests
      ✓ specifying allowPullRequests: public in the default branch allows all
      ✓ specifying allowPullRequests: collaborators in the default branch disallows public
      ✓ user name not checked for pushes, so status is created
    Statuses API: result status handler
      ✓ task success gets a success comment (41ms)
      ✓ task failure gets a failure comment (38ms)
      ✓ task exception gets a failure comment
    Checks API: result status handler
      ✓ task success gets a success comment
      ✓ task failure gets a failure comment
      ✓ task exception gets a failure comment
      ✓ successful task started by decision task gets a success comment (52ms)
{"EnvVersion":"2.0","Fields":{"message":"Unknown reasonResolved or state in exchange/taskcluster-queue/v1/task-completed!\n      Resolution reason received: banana. State received: completed. Add these to the handlers map.\n      TaskId: banana, taskGroupId: AXB-sjV-SoCyibyq3P32ow","name":"Error","stack":"Error: Unknown reasonResolved or state in exchange/taskcluster-queue/v1/task-completed!\n      Resolution reason received: banana. State received: completed. Add these to the handlers map.\n      TaskId: banana, taskGroupId: AXB-sjV-SoCyibyq3P32ow\n    at Handlers.statusHandler (/taskcluster/services/github/src/handlers.js:432:30)","v":1},"Hostname":"815890ce2f6e","Logger":"taskcluster.github.root.handlers","Pid":112,"Severity":3,"Timestamp":1552087598361000000,"Type":"monitor.error","message":"Error: Unknown reasonResolved or state in exchange/taskcluster-queue/v1/task-completed!\n      Resolution reason received: banana. State received: completed. Add these to the handlers map.\n      TaskId: banana, taskGroupId: AXB-sjV-SoCyibyq3P32ow\n    at Handlers.statusHandler (/taskcluster/services/github/src/handlers.js:432:30)","serviceContext":{"service":"github"},"severity":"ERROR"}
      ✓ Undefined state/reasonResolved in the task exchange message -> neutral status (56ms)
    Statuses API: initial status handler
      ✓ create pending status when task is defined
    Checks API: initial status handler
      ✓ create pending status when task is defined (53ms)
  handlers (real)
    jobHandler
      ✓ valid push (owner is collaborator) creates a taskGroup
      ✓ valid pull_request (user is collaborator) creates a taskGroup (52ms)
      ✓ valid push (but not collaborator) creates a taskGroup
      ✓ valid tag push (but not collaborator) creates a taskGroup
      ✓ invalid YAML results in a comment
(node:112) UnhandledPromiseRejectionWarning: #<Object>
(node:112) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 13)
      ✓ error creating task is reported correctly
(node:112) PromiseRejectionHandledWarning: Promise rejection was handled asynchronously (rejection id: 13)
      ✓ not an org member or collaborator is reported correctly for pull requests
      ✓ specifying allowPullRequests: public in the default branch allows all
      ✓ specifying allowPullRequests: collaborators in the default branch disallows public
      ✓ user name not checked for pushes, so status is created
    Statuses API: result status handler

Comment 1

[Dustin J. Mitchell [:dustin] (he/him)]

This is fixed now.