1534028 - Remove omni format checking from SeaMonkey build files.

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, enhancement)

Description

[Frank-Rainer Grahl (:frg)]

We are checking MOZ_OMNIJAR and MOZ_PACKAGER_FORMAT omni in our build files.
I am not aware that there is another format still used and supported in SeaMonkey. We are the only product doing checks outside of toolkit and I think it can safely be removed.

Comment 1

[Frank-Rainer Grahl (:frg)]

Attachment: 1534028-omni.patch

Tested with 2.53 and 2.57

Comment 2

[Ian Neal]

Comment on attachment 9049750 [details] [diff] [review]
1534028-omni.patch

When there is a good chunk of whitespace only changes it would be useful having two versions of the patch uploaded, the one for checkin with the white space changes and the one for review without the white space changes.
r/a=me

Comment 3

[Frank-Rainer Grahl (:frg)]

Attachment: 1534028-omni-cc2.patch

@[e-mail] is always removed if found so no need to check for MOZ_UPDATER.

Setting a+ works :)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/2cf104a9541f
Remove MOZ_OMNIJAR defines and checks from suite. r=IanN
https://hg.mozilla.org/comm-central/rev/eaecfb05b4a4
Remove update.locale unconditionally during install. r=me

Comment 5

[Frank-Rainer Grahl (:frg)]

https://hg.mozilla.org/releases/comm-esr60/rev/71052d0667bda17390ff6dbc0449d5506a9f6353
Remove MOZ_OMNIJAR defines and checks from suite. r=IanN a=IanN

https://hg.mozilla.org/releases/comm-esr60/rev/dbe20c1319c72baa66291e611056ee75f7865e29
Remove update.locale unconditionally during install. r=me a=me

Comment 6

[Frank-Rainer Grahl (:frg)]

Target 2.53.1
https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/fc0a45cb7856e1613d6cbcc358321c6869f7951c
Remove MOZ_OMNIJAR defines and checks from suite. r=IanN a=IanN

https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/f781802885952092ed627ec21527871ce3302a43
Remove update.locale unconditionally during install. r=me a=me