1534074 - Perma TEST-UNEXPECTED-FAIL | <issue category="Correctness" errorLine1=" AppWidgetManager appWidgetManager = getApplicationContext().getSystemService(AppWidgetManager.class);"

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Treeherder Bug Filer]

#[markdown(off)]
Filed by: archaeopteryx [at] coole-files.de

https://treeherder.mozilla.org/logviewer.html#?job_id=232934470&repo=mozilla-central

https://queue.taskcluster.net/v1/task/emCvtqTVTxSl5QhPeJhHug/runs/0/artifacts/public/logs/live_backing.log

These are from bug 1526926 etc.

[task 2019-03-09T22:06:48.693Z] 22:06:48 INFO - BUILD FAILED in 41s
[task 2019-03-09T22:06:48.693Z] 22:06:48 INFO - 47 actionable tasks: 1 executed, 46 up-to-date
[task 2019-03-09T22:06:49.305Z] 22:06:49 INFO - TinderboxPrint: report<br/><a href="https://queue.taskcluster.net/v1/task/emCvtqTVTxSl5QhPeJhHug/runs/0/artifacts/public/android/lint/lint-results-withoutGeckoBinariesDebug.html">HTML withoutGeckoBinariesDebug report</a>, visit "Inspect Task" link for details
[task 2019-03-09T22:06:49.305Z] 22:06:49 INFO - TinderboxPrint: report<br/><a href="https://queue.taskcluster.net/v1/task/emCvtqTVTxSl5QhPeJhHug/runs/0/artifacts/public/android/lint/lint-results-withoutGeckoBinariesDebug.xml">XML withoutGeckoBinariesDebug report</a>, visit "Inspect Task" link for details
[task 2019-03-09T22:06:49.305Z] 22:06:49 INFO - TEST-UNEXPECTED-FAIL | android-lint | Lint found errors in the project; aborting build. See the report at: https://queue.taskcluster.net/v1/task/emCvtqTVTxSl5QhPeJhHug/runs/0/artifacts/public/android/lint/lint-results-withoutGeckoBinariesDebug.html
[task 2019-03-09T22:06:49.306Z] 22:06:49 INFO - SUITE-START | android-lint | withoutGeckoBinariesDebug
[task 2019-03-09T22:06:49.307Z] 22:06:49 INFO - TEST-UNEXPECTED-FAIL | <issue category="Correctness" errorLine1=" AppWidgetManager appWidgetManager = getApplicationContext().getSystemService(AppWidgetManager.class);" errorLine2=" ~~~~~~~~~~~~~~~~" explanation="This check scans through all the Android API calls in the application and warns about any calls that are not available on **all** versions targeted by this application (according to its minimum SDK attribute in the manifest).&#10;&#10;If you really want to use this API and don't need to support older devices just set the `minSdkVersion` in your `build.gradle` or `AndroidManifest.xml` files.&#10;&#10;If your code is **deliberately** accessing newer APIs, and you have ensured (e.g. with conditional execution) that this code will only ever be called on a supported platform, then you can annotate your class or method with the `@TargetApi` annotation specifying the local minimum SDK to apply, such as `@TargetApi(11)`, such that this check considers 11 rather than your manifest file's minimum SDK as the required API level.&#10;&#10;If you are deliberately setting `android:` attributes in style definitions, make sure you place this in a `values-v`*NN* folder in order to avoid running into runtime conflicts on certain devices where manufacturers have added custom attributes whose ids conflict with the new ones on later platforms.&#10;&#10;Similarly, you can use tools:targetApi=&quot;11&quot; in an XML file to indicate that the element will only be inflated in an adequate context." id="NewApi" message="Call requires API level 23 (current min is 16): android.content.Context#getSystemService" priority="6" quickfix="studio" severity="Error" summary="Calling new methods on older versions">
[task 2019-03-09T22:06:49.307Z] 22:06:49 INFO - TEST-UNEXPECTED-FAIL | <location column="81" file="/builds/worker/workspace/build/src/mobile/android/base/java/org/mozilla/gecko/LauncherActivity.java" line="234" />
[task 2019-03-09T22:06:49.307Z] 22:06:49 INFO - TEST-UNEXPECTED-FAIL | </issue>
[task 2019-03-09T22:06:49.308Z] 22:06:49 INFO - TEST-UNEXPECTED-FAIL | <issue category="Correctness" errorLine1=" if (appWidgetManager != null &amp;&amp; appWidgetManager.isRequestPinAppWidgetSupported()) {" errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~" explanation="This check scans through all the Android API calls in the application and warns about any calls that are not available on **all** versions targeted by this application (according to its minimum SDK attribute in the manifest).&#10;&#10;If you really want to use this API and don't need to support older devices just set the `minSdkVersion` in your `build.gradle` or `AndroidManifest.xml` files.&#10;&#10;If your code is **deliberately** accessing newer APIs, and you have ensured (e.g. with conditional execution) that this code will only ever be called on a supported platform, then you can annotate your class or method with the `@TargetApi` annotation specifying the local minimum SDK to apply, such as `@TargetApi(11)`, such that this check considers 11 rather than your manifest file's minimum SDK as the required API level.&#10;&#10;If you are deliberately setting `android:` attributes in style definitions, make sure you place this in a `values-v`*NN* folder in order to avoid running into runtime conflicts on certain devices where manufacturers have added custom attributes whose ids conflict with the new ones on later platforms.&#10;&#10;Similarly, you can use tools:targetApi=&quot;11&quot; in an XML file to indicate that the element will only be inflated in an adequate context." id="NewApi" message="Call requires API level 26 (current min is 16): android.appwidget.AppWidgetManager#isRequestPinAppWidgetSupported" priority="6" quickfix="studio" severity="Error" summary="Calling new methods on older versions">
[task 2019-03-09T22:06:49.308Z] 22:06:49 INFO - TEST-UNEXPECTED-FAIL | <location column="70" file="/builds/worker/workspace/build/src/mobile/android/base/java/org/mozilla/gecko/LauncherActivity.java" line="237" />
[task 2019-03-09T22:06:49.308Z] 22:06:49 INFO - TEST-UNEXPECTED-FAIL | </issue>
[task 2019-03-09T22:06:49.309Z] 22:06:49 INFO - TEST-UNEXPECTED-FAIL | <issue category="Correctness" errorLine1=" appWidgetManager.requestPinAppWidget(componentName, null, successCallback);" errorLine2=" ~~~~~~~~~~~~~~~~~~~" explanation="This check scans through all the Android API calls in the application and warns about any calls that are not available on **all** versions targeted by this application (according to its minimum SDK attribute in the manifest).&#10;&#10;If you really want to use this API and don't need to support older devices just set the `minSdkVersion` in your `build.gradle` or `AndroidManifest.xml` files.&#10;&#10;If your code is **deliberately** accessing newer APIs, and you have ensured (e.g. with conditional execution) that this code will only ever be called on a supported platform, then you can annotate your class or method with the `@TargetApi` annotation specifying the local minimum SDK to apply, such as `@TargetApi(11)`, such that this check considers 11 rather than your manifest file's minimum SDK as the required API level.&#10;&#10;If you are deliberately setting `android:` attributes in style definitions, make sure you place this in a `values-v`*NN* folder in order to avoid running into runtime conflicts on certain devices where manufacturers have added custom attributes whose ids conflict with the new ones on later platforms.&#10;&#10;Similarly, you can use tools:targetApi=&quot;11&quot; in an XML file to indicate that the element will only be inflated in an adequate context." id="NewApi" message="Call requires API level 26 (current min is 16): android.appwidget.AppWidgetManager#requestPinAppWidget" priority="6" quickfix="studio" severity="Error" summary="Calling new methods on older versions">
[task 2019-03-09T22:06:49.309Z] 22:06:49 INFO - TEST-UNEXPECTED-FAIL | <location column="42" file="/builds/worker/workspace/build/src/mobile/android/base/java/org/mozilla/gecko/LauncherActivity.java" line="249" />
[task 2019-03-09T22:06:49.309Z] 22:06:49 INFO - TEST-UNEXPECTED-FAIL | </issue>
[task 2019-03-09T22:06:49.309Z] 22:06:49 INFO - SUITE-END | android-lint | withoutGeckoBinariesDebug

Comment 1

[Intermittent Failures Robot]

11 failures in 2818 pushes (0.004 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-central: 3
• mozilla-inbound: 2
• try: 5
• autoland: 1

Platform breakdown:

• android-4-0-armv7-api16: 11

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1534074&startday=2019-03-04&endday=2019-03-10&tree=all

Comment 2

[Petru-Mugurel Lingurar [:petru]]

Thanks aryx!
Doesn't seem to be really an issue in the code or in how the app will behave, it's just that Lint doesn't know how to follow that api guard we have and wants the check to be done in place.

Comment 3

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1534074 - Use in place api check to prevent Lint ApiDetector errors; r?AndreiLazar

Previous code was using our own sugary feature26Plus check which Lint doesn't
properly follow.
As such even if the code was properly guarded and behaved correctly Lint would
show errors about improper usage of methods which require higher api levels.
Doing the api check in place ensures it will get picked up by Lint's
ApiDetector and so it will not report about such errors here.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cde32a937730
Use in place api check to prevent Lint ApiDetector errors; r=AndreiLazar

Comment 5

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/cde32a937730

Comment 6

[Intermittent Failures Robot]

4 failures in 2771 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• try: 3
• mozilla-beta: 1

Platform breakdown:

• android-4-0-armv7-api16: 4

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1534074&startday=2019-03-11&endday=2019-03-17&tree=all