1534076 - In Windows high contrast mode the "Save full page", "Save visible" and "My shots" icon labels all become invisible

Status: VERIFIED FIXED

(Firefox :: Screenshots, defect, P3)

Description

[ithompson4]

Attachment: Screenshot_High_Contrast_Invisible_icon_labels.png

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:65.0) Gecko/20100101 Firefox/65.0

Steps to reproduce:

Firefox Developer Edition 66 Beta 14 [testday-20190308]

1. Launch Firefox with a clean profile.
2. Enable Firefox Screenshots (if it isn't already).
3. Enable a Windows High Contrast Theme (Alt + left Shift + Print Screen) and inspect Firefox Screenshots overlay and controls.

Actual results:

When set to Windows High Contrast Theme the "Save full page", "Save visible" and "My shots" icon labels all become invisible.

Expected results:

Firefox screen overlay, control buttons, and control button labels should all be clearly visible.

Comment 1

[ithompson4]

This bug has also been raise on Git https://github.com/mozilla-services/screenshots/issues/5371

If this turns out to be a real bug I would like to work on the fix for this if possible. Thank you

Comment 2

[Cristian Comorasu, QA [:ccomorasu], Releae Desktop QA - Please contact [e-mail]]

Thank you, ithompson4!
Can you please assist us with the regression window? In order to find it easier we suggest to use our mozregression tool.

Link to mozregression:
https://mozilla.github.io/mozregression/install.html

Comment 3

[ithompson4]

Ok. Will download and install the mozregression tool this evening.

Comment 4

[ithompson4]

1. mozregression-gui is installed

2. mozregression-gui and ActivePython 2.7.14 64 bit is installed

3. pip2.7-script.py install -U mozregression was executed from a windows command shell window.

What do I do next?

Comment 5

[Cristian Comorasu, QA [:ccomorasu], Releae Desktop QA - Please contact [e-mail]]

Here are some instructions:

1. Launch mozregression-gui.
2. Click on "File" from the menu bar.
3. From the drop-down list select Run a new bisection.
4. Click Next until the Build selection area.
5. Select the last known good build date, then the first known bad build.
6. Click on Finish.
7. After you verify the first downloaded build select Good/Bad from the mozregression-gui.
8. Repeat step 7 until there are no more downloaded builds.
9. Once the bisection is done, copy the "Bisection informations" in the comment section of this bug.

Thank you for your patience and good luck!

Comment 6

[ithompson4]

Will work on this tonight. One question. How do I select a last known good build date for Firefox Developer as there are so many nightly builds? Would 1 week prior got the relevant Mozilla test day ie 1st March 2019 be OK? Thanks.

Comment 7

[ithompson4]

Attachment: Mozregression_GUI_Bisection_Results.png

Comment 8

[ithompson4]

Note: Used 1st March 2019 as the last known good build date.

pushlog_url: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=3b08a133c893b960f15e014a8f36c954d31fda34&tochange=af29567ecdba5441117b3f01ac2559a3473c3d6a
repo_name: mozilla-central

app_name: firefox
build_date: 2019-03-04
build_file: C:\Users\Michael.mozilla\mozregression\persist\2019-03-04--mozilla-central--firefox-67.0a1.en-US.win64.zip
build_type: nightly
build_url: https://archive.mozilla.org/pub/firefox/nightly/2019/03/2019-03-04-21-50-35-mozilla-central/firefox-67.0a1.en-US.win64.zip
changeset: 8602628e7edaecadea855a64179b329da6ff1f20
pushlog_url: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=8602628e7edaecadea855a64179b329da6ff1f20&tochange=af29567ecdba5441117b3f01ac2559a3473c3d6a
repo_name: mozilla-central
repo_url: https://hg.mozilla.org/mozilla-central

app_name: firefox
build_date: 2019-03-06
build_file: C:\Users\Michael.mozilla\mozregression\persist\2019-03-06--mozilla-central--firefox-67.0a1.en-US.win64.zip
build_type: nightly
build_url: https://archive.mozilla.org/pub/firefox/nightly/2019/03/2019-03-06-16-13-00-mozilla-central/firefox-67.0a1.en-US.win64.zip
changeset: 4ab143dde4dc3424cfedc74b3648fbf2e47fb7bf
pushlog_url: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=8602628e7edaecadea855a64179b329da6ff1f20&tochange=4ab143dde4dc3424cfedc74b3648fbf2e47fb7bf
repo_name: mozilla-central
repo_url: https://hg.mozilla.org/mozilla-central

app_name: firefox
build_date: 2019-03-05
build_file: C:\Users\Michael.mozilla\mozregression\persist\2019-03-05--mozilla-central--firefox-67.0a1.en-US.win64.zip
build_type: nightly
build_url: https://archive.mozilla.org/pub/firefox/nightly/2019/03/2019-03-05-21-41-37-mozilla-central/firefox-67.0a1.en-US.win64.zip
changeset: 996a48b306521112d483b3bd8bede1e4fa23d3fa
pushlog_url: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=996a48b306521112d483b3bd8bede1e4fa23d3fa&tochange=4ab143dde4dc3424cfedc74b3648fbf2e47fb7bf
repo_name: mozilla-central
repo_url: https://hg.mozilla.org/mozilla-central

pushlog_url: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=996a48b306521112d483b3bd8bede1e4fa23d3fa&tochange=4ab143dde4dc3424cfedc74b3648fbf2e47fb7bf
repo_name: mozilla-central

app_name: firefox
build_date: 2019-03-06 11:06:41.472000
build_file: C:\Users\Michael.mozilla\mozregression\persist\3e0cf2f77f07--mozilla-central--target.zip
build_type: inbound
build_url: https://queue.taskcluster.net/v1/task/Lp-2c8R9Qeam9ArPAV3piQ/runs/0/artifacts/public%2Fbuild%2Ftarget.zip
changeset: 3e0cf2f77f07b258e8911ab5fd71a378c46fa1ec
pushlog_url: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=996a48b306521112d483b3bd8bede1e4fa23d3fa&tochange=3e0cf2f77f07b258e8911ab5fd71a378c46fa1ec
repo_name: mozilla-central
repo_url: https://hg.mozilla.org/mozilla-central
task_id: Lp-2c8R9Qeam9ArPAV3piQ

app_name: firefox
build_date: 2019-03-06 10:59:37.822000
build_file: C:\Users\Michael.mozilla\mozregression\persist\b452fad68dc3--mozilla-central--target.zip
build_type: inbound
build_url: https://queue.taskcluster.net/v1/task/BS6-9Ev9QvCmfOeA9VFExg/runs/0/artifacts/public%2Fbuild%2Ftarget.zip
changeset: b452fad68dc3504dd0b41de76112dd64f50466c6
pushlog_url: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=996a48b306521112d483b3bd8bede1e4fa23d3fa&tochange=b452fad68dc3504dd0b41de76112dd64f50466c6
repo_name: mozilla-central
repo_url: https://hg.mozilla.org/mozilla-central
task_id: BS6-9Ev9QvCmfOeA9VFExg

app_name: firefox
build_date: 2019-03-06 05:58:54.213000
build_file: C:\Users\Michael.mozilla\mozregression\persist\a83c218cd961--mozilla-central--target.zip
build_type: inbound
build_url: https://queue.taskcluster.net/v1/task/PMnzx7bgQFunFOvK4S2H3w/runs/0/artifacts/public%2Fbuild%2Ftarget.zip
changeset: a83c218cd961857e02be7bac0ff9c971b026c4ce
pushlog_url: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=a83c218cd961857e02be7bac0ff9c971b026c4ce&tochange=b452fad68dc3504dd0b41de76112dd64f50466c6
repo_name: mozilla-central
repo_url: https://hg.mozilla.org/mozilla-central
task_id: PMnzx7bgQFunFOvK4S2H3w

Comment 9

[Cristian Comorasu, QA [:ccomorasu], Releae Desktop QA - Please contact [e-mail]]

Thank you, ithompson4!

Comment 10

[Paul_B]

There is a similar issue reported a while back here: Bug 1513898. Based on that, I'm going to add this to Screenshots component, for an advised input.

Comment 11

[Mike Taylor [:miketaylr]]

(oops, let's move it back to Screenshots, sorry we're triaging this at the same time)

Comment 12

[Mike Taylor [:miketaylr]]

Cristian, could you verify the mozregression range please? Comment #8 isn't super narrow. Thanks.

Comment 13

[Paul_B]

I've also tried to verify the regression range, and unfortunately, I could not pinpoint a particular fix, but and my results are:

Last good build: 2017-10-15
First bad build: 2017-10-16

changeset: 2ba9ba4fa63b942d8d9401f6ff6e40f5730adcd1
pushlog_url: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=2ba9ba4fa63b942d8d9401f6ff6e40f5730adcd1&tochange=f78d5947333422ab09ec23e3dab0d48538c9d6ad

Comment 14

[Cristian Comorasu, QA [:ccomorasu], Releae Desktop QA - Please contact [e-mail]]

I also recieved the same pushlog:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=2ba9ba4fa63b942d8d9401f6ff6e40f5730adcd1&tochange=f78d5947333422ab09ec23e3dab0d48538c9d6ad

Comment 15

[ithompson4]

Reading through the above comments and links it looks like a genuine issue. Can I work on this? Thanks.

Comment 16

[ithompson4]

Thanks. I will start working on this.

Comment 17

[ithompson4]

Attachment: EnvironmentSetupError.png

Comment 18

[ithompson4]

I am in the process of setting the development environment on Windows 10, using instructions from https://github.com/mozilla-services/screenshots.
I have installed the Developer edition and Node.js. , and I have cloned the repo from https://github.com/mozilla-services/screenshots
I ran the “npm install” command
I then tried to run the “./bin/run-addon -s https://screenshots.dev.mozaws.net” command and got the error message “./bin/run-addon: line 109: : command not found error (please refer to attached screenshot).
What am I missing?

Comment 19

[Liz Henry (:lizzard)]

ithompson, are you still intending to work on this? If you're having trouble with the dev environment, you can ask on #introductions on irc.mozilla.org and I bet someone will help there.

Comment 20

[Liz Henry (:lizzard)]

Ian, do you want to set a priority on this bug? I'm clearing the assignee field.

Comment 21

[Asa Dotzler [:asa]]

Attachment: image.png

I'm unable to reproduce the bug as described in the latest Windows Nightly with the High Contrast Black as my Windows setting.

Comment 22

[BugBot [:suhaib / :marco/ :calixte]]

Clear a needinfo that is pending on an inactive user.

For more information, please visit auto_nag documentation.

Comment 23

[Mihai Boldan, Desktop QA [:mboldan]]

Attachment: Screenshot Windows 11.png

It seems that on Windows 11 the labels are not visible with High Contrast theme enabled.
Note that all other button names or labels are displayed with white color.

Comment 24

[Niklas Baumgardner [:niklas]]

This was fixed bug 1874663 and I'm not able to reproduce in todays Nightly on Windows 11.
Are you able to reproduce this issue in todays Nightly?

Comment 25

[Mihai Boldan, Desktop QA [:mboldan]]

It seems that on the latest Nightly build 124.0a1 (2024-02-07) the issue is no longer reproducible. Somehow I missed the other issue. Thanks for the heads-up.
Tested on Windows 11.

Comment 26

[BugBot [:suhaib / :marco/ :calixte]]

The severity field for this bug is set to S3. However, the accessibility severity is higher, .
:sfoster, could you consider increasing the severity?

For more information, please visit BugBot documentation.

Comment 27

[Sam Foster [:sfoster] (he/him)]

Its good to get this on file, but I think we'll fix it by shipping the new implementation which moves those buttons to browser chrome.

Comment 28

[❌ Anna Yeddi [:ayeddi] ❌ On leave until 2027-01-04]

Attachment: Win11-Night_Sky_HCM_(customized ButtonFace and SelectedItem for clarity).png

Comment 29

[❌ Anna Yeddi [:ayeddi] ❌ On leave until 2027-01-04]

Attachment: Win11-Desert_HCM.png

Since the bug 1789727 was closed, it appears that the text is now visible in Nightly 125.0a1

Comment 30

[Sam Foster [:sfoster] (he/him)]

This was fixed by flipping the pref to default on in nightly - in bug 1789727.

Comment 31

[Ryan VanderMeulen (PTO, back July 27)]

IMO, this should stay open until the new Screenshots component rides the trains.

Comment 32

[Sam Foster [:sfoster] (he/him)]

Fixed in nightly with the pref flipped in bug 1870127 to make the new implementation the default.

Comment 33

[Simona Badau, Desktop QA, PTO 22-30June]

Verified as fixed using the latest Nightly 127.0a1 on Windows 10 and Windows 11 - the Save visible and Save Full Page labels are now visible.