1534084 - Merge Phablicator Revisions with Attachments

Status: REOPENED

(bugzilla.mozilla.org :: User Interface, enhancement)

Description

[Kohei Yoshino [:kohei]]

Attachment: Screenshot of Bug 1312163: duplicated Phab requests

Since :dkl has added the Phablicator Revisions to the modal UI modules, Phablicator attachments are displayed redundantly on the bug page. Let’s “KonMari” the clutter.

Comment 1

[David Lawrence [:dkl]]

mcote and I had planned to do this so I will take this.

Comment 2

[David Lawrence [:dkl]]

Attachment: GitHub Pull Request

Comment 3

[David Lawrence [:dkl]]

Merged to master.

Comment 4

[Kohei Yoshino [:kohei]]

Looks like we have to back this out. I’ve just realized that if Phablicator requests are hidden from the attachment list, the details link will be gone and uplift requests cannot be made. Maybe we should rather merge the Phabricator Revisions module into the Attachments module.

Comment 5

[Kohei Yoshino [:kohei]]

Well, the details link is still displayed inline, but you need to scroll down to find it.

Comment 6

[Kohei Yoshino [:kohei]]

Attachment: Back out PR

Comment 7

[Emma Humphries ☕️🎸🧞‍♀️✨ (she/they) [:emceeaich] (Pacific Time) use needinfo]

Is this still needed?

Comment 8

[Kohei Yoshino [:kohei]]

I think so. 1 Phablicator request doesn’t matter, but sometimes there are 5+ requests like Bug 1519434, and the redundant Phablicator Revisions and Attachments sections waste a large portion of the page. This can be WONTFIX :dkl’s original PR works if uplift requests will be done directly on Phablicator, otherwise the Details link is still needed as I said earlier in Comment 4.

Comment 9

[David Lawrence [:dkl]]

Attachment: GitHub Pull Request