Closed Bug 1534088 Opened 5 years ago Closed 5 years ago

Unable to change Firefox's captive portal to a working URL.

Categories

(Core :: Networking, defect)

65 Branch
defect
Not set
normal

Tracking

()

RESOLVED INVALID

People

(Reporter: dev, Unassigned)

References

Details

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:65.0) Gecko/20100101 Firefox/65.0

Steps to reproduce:

I changed captivedetect.{canonicalURL, canonicalContent} to my own captive portal and text, respectively (http://nil.carlosnunez.me, "success").

Actual results:

Firefox shows me the "You must log in" hover notification anyway, even after restarting.

Expected results:

No notification bar should have been shown.

Moving to Toolkit: Notifications and Alerts, please correct if this should be a different component.

Component: Untriaged → Notifications and Alerts
Product: Firefox → Toolkit
Blocks: 562917
Component: Notifications and Alerts → Networking
Product: Toolkit → Core

(In reply to dev from comment #0)

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:65.0) Gecko/20100101 Firefox/65.0

Steps to reproduce:

I changed captivedetect.{canonicalURL, canonicalContent} to my own captive portal and text, respectively (http://nil.carlosnunez.me, "success").

That URL returns "i love socks.\n" not "success\n".

Make it return success (with a newline at the end), or make it return "i love socks." (no newline) and change the pref to "i love socks." (no newline)

Status: UNCONFIRMED → RESOLVED
Closed: 5 years ago
Resolution: --- → INVALID

Hello, Valentin!

My site does not return a newline:

<<master>> nil]$: curl nil.carlosnunez.me | hexdump -C
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100    14  100    14    0     0     55      0 --:--:-- --:--:-- --:--:--    56
00000000  69 20 6c 6f 76 65 20 73  6f 63 6b 73 2e 0a        |i love socks..|
0000000e

My captivedetect.canonicalContent option does not include a newline as well. If I knew how to dump that on the command line, I would.

Status: RESOLVED → UNCONFIRMED
Resolution: INVALID → ---

(In reply to dev from comment #3)

Hello, Valentin!

My site does not return a newline:

> 00000000  69 20 6c 6f 76 65 20 73  6f 63 6b 73 2e 0a        |i love socks..|
                                                    ^
                                                    |
                                                    +- this is a newline
Status: UNCONFIRMED → RESOLVED
Closed: 5 years ago5 years ago
Resolution: --- → INVALID

darn it; it totally was! changing the page to success (with newline) fixed it. Thanks!

You need to log in before you can comment on or make changes to this bug.