Closed Bug 1534111 Opened 6 years ago Closed 6 years ago

[wpt-sync] Sync PR 15703 - CacheStorage: Set the Response mime type based on stored content-header.

Categories

(Testing :: web-platform-tests, enhancement, P4)

Product:
Testing
Component:
web-platform-tests
Type:
enhancement

Tracking

(firefox68 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla68
Tracking Flags:
Tracking Status
firefox68 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 15703 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/15703
Details from upstream follow.

Ben Kelly <wanderview@chromium.org> wrote:

CacheStorage: Set the Response mime type based on stored content-header.

Previously the Response mime type was never set when reading from a
Cache. This resulted in empty string blob.type values and could also
prevent code cache from being generated if a script Response was put
back into a Cache.

This CL makes us at least generate a mime type if a content-type header
is available. This is a partial solution since the mime type could also
be set via sniffing at load time. To support that we will need to
explicitly store a mime type on disk in the cache. This will be done
later in crbug.com/938939.

Bug: 937963
Change-Id: Iabfe3909ff35957501ef33132af2a0c1f70c5c94

Reviewed-on: https://chromium-review.googlesource.com/1506213
WPT-Export-Revision: 87230357fabbe32cdf4c6a6515623deb2e8959d2

Ran 3 tests and 73 subtests OK : 3 PASS : 64 FAIL : 9 New tests that have failures or other problems: /service-workers/cache-storage/serviceworker/cache-match.https.html MIME type should be frozen at response construction.: FAIL /service-workers/cache-storage/window/cache-match.https.html MIME type should be frozen at response construction.: FAIL /service-workers/cache-storage/worker/cache-match.https.html MIME type should be frozen at response construction.: FAIL
Pushed by james@hoppipolla.co.uk: https://hg.mozilla.org/integration/mozilla-inbound/rev/f6ac89e9c244 [wpt PR 15703] - CacheStorage: Set the Response mime type based on stored content-header., a=testonly https://hg.mozilla.org/integration/mozilla-inbound/rev/d783e54adf7f [wpt PR 15703] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/f6ac89e9c244
https://hg.mozilla.org/mozilla-central/rev/d783e54adf7f

Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox68: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in before you can comment on or make changes to this bug.