1534186 - Profile manager automatically removing profiles that are temporarily offline

Status: VERIFIED FIXED

(Toolkit :: Startup and Profile System, defect)

Description

[Kestrel]

STR:

1. Have a profile path in profiles.ini that is currently offline.
2. Visit about:profiles or start with firefox -P.
3. Offline profile is automatically removed from profiles.ini.

There are many legitimate reasons for a profile path being temporarily inaccessible (unmounted, separate media, powered down, unplugged, networking issue etc.) and does not mean it can be assumed to be permanently missing. This doesn't just affect non-relative paths since it is possible to mount remote folders into relative paths (using mount --bind on Linux).

Regressed by Bug 1530615.

Comment 1

[ovidiu boca[:Ovidiu]]

Hi Kestrel,

I want to verify this issue but I'm not sure how can I set a profile to be offline, can you please give me some more details about the reproducing steps for this? Thanks

Comment 2

[Kestrel]

Go to the profiles directory referred to in about:support and edit profiles.ini there, adding the following profile entry:

[Profile2]
Name=TempOfflinePath
IsRelative=0
Path=/some/directory/that/does/not/exist/

Comment 3

[Dave Townsend [:mossop]]

I've backed out https://hg.mozilla.org/mozilla-central/rev/455e57b39067 which caused this issue, thanks for spotting it so quickly.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Bug 1530615 was backed out.

Comment 5

[ovidiu boca[:Ovidiu]]

Hi, Kestrel can you please double check this issue and tell us if you are still able to reproduce it? Thanks

Comment 6

[Kestrel]

I can verify this is fixed on latest Nightly 68.0a1 (2019-03-30) and Beta 67.0b6 on Ubuntu 18.10.