1534211 - Remove a static constructor

Status: RESOLVED FIXED

(Core :: Storage: Quota Manager, enhancement, P2)

Description

[Jan Varga [:janv]]

See https://bugzilla.mozilla.org/show_bug.cgi?id=1526891#c23

Comment 1

[Jan Varga [:janv]]

I think this added a static ctor:
https://searchfox.org/mozilla-central/rev/486b64e4bff86b7988af8c8b80845404ad197533/dom/quota/ActorsParent.cpp#1321

Comment 2

[Jan Varga [:janv]]

Attachment: Bug 1534211 - Remove a static constructor; r=asuth

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/00f84bd04433
Remove a static constructor; r=asuth

Comment 4

[Daniel Varga [:dvarga]]

Backed out 2 changesets (Bug 1534211, Bug 1533651) for xpcshell failure at devtools/client/responsive.html/test/unit/test_change_device.js on a CLOSED TREE
and assertion failure: GetPersistenceFile - C:\Users\task_1553642342\AppData\Local\Temp\gv_measurements.jsonAssertion failure: gBaseDirPath, at z:/build/build/src/dom/quota/ActorsParent.cpp:2548

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&selectedJob=236245966&revision=00f84bd04433fb09075f32c578fda35a28394965

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=236243703&repo=mozilla-inbound&lineNumber=864
and
https://treeherder.mozilla.org/logviewer.html#?job_id=236243720&repo=mozilla-inbound

23:43:32 INFO - **** TELEMETRY: PersistenceThreadPersist
23:43:32 INFO - **** TELEMETRY: GetPersistenceFile - C:\Users\task_1553642342\AppData\Local\Temp\gv_measurements.jsonAssertion failure: gBaseDirPath, at z:/build/build/src/dom/quota/ActorsParent.cpp:2548
23:43:43 INFO - #01: nsObserverList::NotifyObservers(nsISupports *,char const *,char16_t const *) [xpcom/ds/nsObserverList.cpp:65]
23:43:43 INFO - #02: nsObserverService::NotifyObservers(nsISupports *,char const *,char16_t const *) [xpcom/ds/nsObserverService.cpp:296]
23:43:43 INFO - #03: ScopedXPCOM::~ScopedXPCOM() [xpcom/tests/TestHarness.h:106]
23:43:43 INFO - #04: mozilla::RunGTestFunc(int *,char * *) [testing/gtest/mozilla/GTestRunner.cpp:112]
23:43:43 INFO - #05: XREMain::XRE_mainStartup(bool *) [toolkit/xre/nsAppRunner.cpp:3769]
23:43:43 INFO - #06: XREMain::XRE_main(int,char * * const,mozilla::BootstrapConfig const &) [toolkit/xre/nsAppRunner.cpp:4714]
23:43:43 INFO - #07: XRE_main(int,char * * const,mozilla::BootstrapConfig const &) [toolkit/xre/nsAppRunner.cpp:4811]
23:43:43 INFO - #08: mozilla::BootstrapImpl::XRE_main(int,char * * const,mozilla::BootstrapConfig const &) [toolkit/xre/Bootstrap.cpp:45]
23:43:45 INFO - #09: NS_internal_main(int,char * *,char * *) [browser/app/nsBrowserApp.cpp:291]
23:43:45 INFO - #10: wmain [toolkit/xre/nsWindowsWMain.cpp:131]
23:43:45 INFO - #11: static int __scrt_common_main_seh() [f:/dd/vctools/crt/vcstartup/src/startup/exe_common.inl:288]
23:43:45 INFO - #12: kernel32.dll + 0x53c45
23:43:45 INFO - #13: ntdll.dll + 0x637f5
23:43:45 INFO - #14: ntdll.dll + 0x637c8
23:43:45 INFO - mozcrash INFO | Copy/paste: Z:\task_1553642342\build\win32-minidump_stackwalk.exe Z:\task_1553642342\build\tests\gtest\57197426-39f5-4862-8060-43bc108d00a1.dmp Z:\task_1553642342\build\symbols
23:44:05 INFO - mozcrash INFO | Saved minidump as Z:\task_1553642342\build\blobber_upload_dir\57197426-39f5-4862-8060-43bc108d00a1.dmp
23:44:05 INFO - mozcrash INFO | Saved app info as Z:\task_1553642342\build\blobber_upload_dir\57197426-39f5-4862-8060-43bc108d00a1.extra
23:44:05 WARNING - PROCESS-CRASH | gtest | application crashed [@ mozilla::dom::quota::QuotaManager::Observer::Observe(nsISupports *,char const *,char16_t const *)]
23:44:05 INFO - Crash dump filename: Z:\task_1553642342\build\tests\gtest\57197426-39f5-4862-8060-43bc108d00a1.dmp
23:44:05 INFO - Operating system: Windows NT
23:44:05 INFO - 6.1.7601 Service Pack 1
23:44:05 INFO - CPU: x86
23:44:05 INFO - GenuineIntel family 6 model 63 stepping 2
23:44:05 INFO - 8 CPUs
23:44:05 INFO - GPU: UNKNOWN
23:44:05 INFO - Crash reason: EXCEPTION_BREAKPOINT
23:44:05 INFO - Crash address: 0x563190a8
23:44:05 INFO - Process uptime: 717 seconds

Comment 5

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c8f3f0b484e5
Backed out 2 changesets (bug 1534211, bug 1533651) for xpcshell failure at devtools/client/responsive.html/test/unit/test_change_device.js on a CLOSED TREE

Comment 6

[Jan Varga [:janv]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=226346436d75c8a63b4f3ffce05268514f5ca6d6

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/95a3cf26ab48
Remove a static constructor; r=asuth

Comment 8

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/95a3cf26ab48